Skip to content

Commit 5269899

Browse files
authored
Fix for max_chunk_size (#247)
* fix for max_chuck_size * Give max_chunk_size a default
1 parent fdcd8f3 commit 5269899

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/client/content/config/tabs/models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,12 +163,12 @@ def edit_model(model_type: str, action: Literal["add", "edit"], model_id: str =
163163
key="add_model_frequency_penalty",
164164
)
165165
else:
166-
model["chunk_size"] = st.number_input(
166+
model["max_chunk_size"] = st.number_input(
167167
"Max Chunk Size:",
168168
help=help_text.help_dict["chunk_size"],
169169
min_value=0,
170170
key="add_model_max_chunk_size",
171-
value=model.get("chunk_size", 8191),
171+
value=model.get("max_chunk_size", 8191),
172172
)
173173
submit = False
174174
button_col_format = st.columns([1.2, 1.4, 6, 1.4])

src/common/schema.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ class LanguageModelParameters(BaseModel):
123123
class EmbeddingModelParameters(BaseModel):
124124
"""Embedding Model Parameters (also used by settings.py)"""
125125

126-
max_chunk_size: Optional[int] = Field(default=None, description="Max Chunk Size for Embedding Models.")
126+
max_chunk_size: Optional[int] = Field(default=8192, description="Max Chunk Size for Embedding Models.")
127127

128128

129129
class ModelAccess(BaseModel):

0 commit comments

Comments
 (0)