Skip to content

/more/ should include context for the matching lines #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cnst opened this issue Oct 17, 2013 · 1 comment
Closed

/more/ should include context for the matching lines #673

cnst opened this issue Oct 17, 2013 · 1 comment

Comments

@cnst
Copy link

cnst commented Oct 17, 2013

Since the /more/ page is already somewhat relaxed, providing more in-context results compared to the original search results from which it is linked from, it might as well include some context to the lines found — perhaps a standard 3-lines before, 3-lines after, would nice.

For example, in the nginx source, I want to figure out what diagnostic messages are available with each log level, for error_log. However, /more/trunk/src/http/ngx_http_request.c?refs=ngx_log_error page only lists the actual levels, but doesn't list the text message of the warnings, making the grokking difficult.

@tarzanek
Copy link
Contributor

see #638 - I think the request for config lines is there, too
I won't close this as dup because this is for "more" page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants