Replies: 1 comment 3 replies
-
|
I believe we discussed ideas for this in a community meeting a while back. It was around the time we got As a rough draft (not looking up the old discussion since I don't think it went very far), maybe it would look something like this: [tool.scikit-build.config-setting]
"zmq.prefix" = {type = "str", help = "Location"}
"zmq.libzmq" = {type = "str", help = "Can be bundled"}
[tool.scikit-build.define]
ZMQ_PREFIX = {config-setting = "zmq.prefix"}
ZMQ_LIBZMQ = "OFF"
[[tool.scikit-build.overrides]]
if.config-setting."zmq.libzmq" = "bundled"
messages.after-success = "{green}Using bundled libzmq"
define.ZMQ_LIBZMQ = "ON" |
Beta Was this translation helpful? Give feedback.
3 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
PEP 517 config-settings are used to set build-backend inputs, and can be used to set cmake variables with
-C cmake.define.NAME. Is it possible (or advisable) to be able to register my own config-settings keys for my package and have them available in cmake? Or are config-settings really meant to be only for the build system itself, not for the package being built?I can (and do) use CMake defines for the inputs I want, but for a user-facing documentation of these options, I'd rather have my own settings so that I can have a Python-standard interface for configuring pyzmq builds, independent of the underlying build implementation. So e.g. if I switched to a different underlyingsetup, user install commands wouldn't need to change. I have this already with environment variables, but it would be nice if I could migrate to PEP 517 args e.g.
-C zmq.libzmq="bundled". Is this something that is possible with scikit-build-core and/or something worth pursuing? As it stands, I thinkexport ZMQ_PREFIX=/foois a better interface/experience than-C cmake.define.ZMQ_PREFIX=/foo, because it will still work if I try out meson, etc. (and indeed still works the same with cmake as it did with setuptools).Beta Was this translation helpful? Give feedback.
All reactions