fix: use minLength and maxLength when mocking strings if defined (#2130)

SampsaKaskela · web-flow · commit 48738eebf2c4 · 2025-05-31T12:03:16.000-04:00
* fix: use minLength and maxLength when mocking strings if defined

* fix: fix tests

* fix: fix wrong minLength and maxLength in samples
diff --git a/packages/mock/src/faker/getters/scalar.ts b/packages/mock/src/faker/getters/scalar.ts
@@ -234,7 +234,11 @@ export const getMockScalar = ({
     }
 
     case 'string': {
-      let value = 'faker.string.alpha(20)';
+      const length =
+        item.minLength !== undefined || item.maxLength !== undefined
+          ? `{length: {min: ${item.minLength ?? 0}, max: ${item.maxLength ?? (item.minLength ?? 0) + 20}}}`
+          : 20;
+      let value = `faker.string.alpha(${length})`;
       const stringImports: GeneratorImport[] = [];
 
       if (item.enum) {
diff --git a/samples/basic/petstore.yaml b/samples/basic/petstore.yaml
@@ -143,8 +143,8 @@ components:
         name:
           type: string
           description: 'Name of pet'
-          maxLength: 0
-          minLength: 40
+          minLength: 0
+          maxLength: 40
         age:
           type: integer
           format: int32
diff --git a/samples/react-query/basic/petstore.yaml b/samples/react-query/basic/petstore.yaml
@@ -143,8 +143,8 @@ components:
         name:
           type: string
           description: 'Name of pet'
-          maxLength: 0
-          minLength: 40
+          minLength: 0
+          maxLength: 40
         age:
           type: integer
           format: int32
diff --git a/samples/react-query/custom-client/petstore.yaml b/samples/react-query/custom-client/petstore.yaml
@@ -143,8 +143,8 @@ components:
         name:
           type: string
           description: 'Name of pet'
-          maxLength: 0
-          minLength: 40
+          minLength: 0
+          maxLength: 40
         age:
           type: integer
           format: int32
diff --git a/samples/react-query/form-data-mutator/petstore.yaml b/samples/react-query/form-data-mutator/petstore.yaml
@@ -143,8 +143,8 @@ components:
         name:
           type: string
           description: 'Name of pet'
-          maxLength: 0
-          minLength: 40
+          minLength: 0
+          maxLength: 40
         age:
           type: integer
           format: int32
diff --git a/samples/react-query/form-data/petstore.yaml b/samples/react-query/form-data/petstore.yaml
@@ -143,8 +143,8 @@ components:
         name:
           type: string
           description: 'Name of pet'
-          maxLength: 0
-          minLength: 40
+          minLength: 0
+          maxLength: 40
         age:
           type: integer
           format: int32
diff --git a/samples/react-query/form-url-encoded-mutator/petstore.yaml b/samples/react-query/form-url-encoded-mutator/petstore.yaml
@@ -143,8 +143,8 @@ components:
         name:
           type: string
           description: 'Name of pet'
-          maxLength: 0
-          minLength: 40
+          minLength: 0
+          maxLength: 40
         age:
           type: integer
           format: int32
diff --git a/samples/react-query/form-url-encoded/petstore.yaml b/samples/react-query/form-url-encoded/petstore.yaml
@@ -143,8 +143,8 @@ components:
         name:
           type: string
           description: 'Name of pet'
-          maxLength: 0
-          minLength: 40
+          minLength: 0
+          maxLength: 40
         age:
           type: integer
           format: int32
diff --git a/samples/react-query/hook-mutator/petstore.yaml b/samples/react-query/hook-mutator/petstore.yaml
@@ -143,8 +143,8 @@ components:
         name:
           type: string
           description: 'Name of pet'
-          maxLength: 0
-          minLength: 40
+          minLength: 0
+          maxLength: 40
         age:
           type: integer
           format: int32
diff --git a/tests/specifications/models-with-special-char.yaml b/tests/specifications/models-with-special-char.yaml
@@ -143,8 +143,8 @@ components:
         name:
           type: string
           description: 'Name of pet'
-          maxLength: 0
-          minLength: 40
+          minLength: 0
+          maxLength: 40
         age:
           type: integer
           format: int32
