Vendor Zord#162
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… Noun Figma designs
…ugin-sort-imports (solves .css ordering issue)
…s, implement correct type styles, update radii
olegakbarov
reviewed
Jan 11, 2023
olegakbarov
reviewed
Jan 11, 2023
olegakbarov
reviewed
Jan 11, 2023
olegakbarov
approved these changes
Jan 11, 2023
Contributor
olegakbarov
left a comment
olegakbarov
left a comment
There was a problem hiding this comment.
big LGTM from my side
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very extensive re-work of site styles + base components using a vendored-in version of Zord that we can modify as we please.
Heading + Paragraph (+ Span)Need to look at link treatments eg. in ModalsDefinitely need to look at counts in the Browse menuDefinitely need to look at the Traits dropdown styles on the collection pagelightFont instances removedHave removed global font treatments in styles.css, needs cleanupmediumFont instances need to be done carefully!Eliminate use of .zord-attributesHeadingReplace .nouns-market-traitsTODOS marked as ZORDTODO in site files in some places to revisitradii need updates (+ apply to buttons + containers)CSS import sorting needs to be dealt with. Currently in _app.tsx globals.css is being imported before reset.css, which has the potential to reset styles defined in globals.cssPrevent reordering css imports trivago/prettier-plugin-sort-imports#95, potential fix here but unmerged: Do not reorder side effect nodes #110 trivago/prettier-plugin-sort-imports#111, (possibly replace with forked version here: https://www.npmjs.com/package/@ianvs/prettier-plugin-sort-imports, the author indicates it will be maintained moving forward)Remove use of !importantProbably need to clean up fontsizes + lineheights (remove some after changing others)TODO: