fix: disable auditing before model initialization (#758)

Author: evgeek

src/Auditable.php

@@ -63,7 +63,7 @@ trait Auditable
      */
     public static function bootAuditable()
     {
-        if (!self::$auditingDisabled && static::isAuditingEnabled()) {
+        if (static::isAuditingEnabled()) {
             static::observe(new AuditableObserver());
         }
     }

tests/Functional/AuditingTest.php

@@ -407,6 +407,31 @@ public function itDisablesAndEnablesAuditingBackAgain()
         $this->assertSame(3, Article::count());
     }
 
+    /**
+     * @test
+     */
+    public function itDisablesAndEnablesAuditingBackAgainViaFacade()
+    {
+        // Auditing is enabled by default
+        $this->assertFalse(Article::$auditingDisabled);
+
+        Article::disableAuditing();
+
+        factory(Article::class)->create();
+
+        $this->assertSame(1, Article::count());
+        $this->assertSame(0, Audit::count());
+
+        // Enable Auditing
+        Article::enableAuditing();
+        $this->assertFalse(Article::$auditingDisabled);
+
+        factory(Article::class)->create();
+
+        $this->assertSame(2, Article::count());
+        $this->assertSame(1, Audit::count());
+    }
+
     /**
      * @test
      * @return void

tests/Unit/AuditableTest.php

@@ -75,15 +75,16 @@ public function itWillAlwaysAuditModelsWhenNotRunningFromTheConsole()
      * @group Auditable::bootAuditable
      * @test
      */
-    public function itWillNotBootTraitWhenStaticFlagIsSet()
+    public function itWillBootTraitWhenStaticFlagIsSet()
     {
         App::spy();
 
         Article::$auditingDisabled = true;
 
-        new Article();
+        $article = new Article();
 
-        App::shouldNotHaveReceived('runningInConsole');
+        $this->assertFalse($article->readyForAuditing());
+        App::shouldReceive('runningInConsole');
 
         Article::$auditingDisabled = false;
     }