feat(linter): convert oxlint to NAPI app

Author: overlookmotel

.github/generated/ast_changes_watch_list.yml

@@ -3,6 +3,8 @@
 
 src:
   - '.github/generated/ast_changes_watch_list.yml'
+  - 'apps/oxlint/src-js/generated/constants.mjs'
+  - 'apps/oxlint/src/generated/raw_transfer_constants.rs'
   - 'crates/oxc_allocator/src/generated/assert_layouts.rs'
   - 'crates/oxc_allocator/src/generated/fixed_size_constants.rs'
   - 'crates/oxc_allocator/src/pool/fixed_size.rs'
@@ -64,8 +66,6 @@ src:
   - 'crates/oxc_syntax/src/serialize.rs'
   - 'crates/oxc_syntax/src/symbol.rs'
   - 'crates/oxc_traverse/src/generated/scopes_collector.rs'
-  - 'napi/oxlint/src-js/generated/constants.mjs'
-  - 'napi/oxlint/src/generated/raw_transfer_constants.rs'
   - 'napi/parser/generated/constants.mjs'
   - 'napi/parser/generated/deserialize/js.mjs'
   - 'napi/parser/generated/deserialize/ts.mjs'

.github/workflows/ci.yml

@@ -26,7 +26,8 @@ jobs:
           save-cache: ${{ github.ref_name == 'main' }}
           cache-key: warm
       - run: cargo ck
-      - run: cargo test --all-features
+      - run: cargo test --workspace --all-features --exclude website
+      - run: cargo test -p website # Run separately to avoid feature unification problems with `oxlint`
       - run: git diff --exit-code # Must commit everything
 
   test-ubuntu-aarch64:
@@ -41,7 +42,8 @@ jobs:
           save-cache: ${{ github.ref_name == 'main' }}
           cache-key: warm-aarch64
       - run: cargo ck
-      - run: cargo test --all-features
+      - run: cargo test --workspace --all-features --exclude website
+      - run: cargo test -p website # Run separately to avoid feature unification problems with `oxlint`
       - run: git diff --exit-code # Must commit everything
 
   test-mac: # Separate job to save a job on PRs
@@ -56,7 +58,8 @@ jobs:
           save-cache: ${{ github.ref_name == 'main' }}
           cache-key: warm
       - run: cargo ck
-      - run: cargo test --all-features
+      - run: cargo test --workspace --all-features --exclude website
+      - run: cargo test -p website # Run separately to avoid feature unification problems with `oxlint`
       - run: git diff --exit-code # Must commit everything
 
   test-windows:
@@ -98,7 +101,12 @@ jobs:
           save-if: ${{ github.ref_name == 'main' }}
           shared-key: windows-latest
 
-      - run: cargo test --all-features # cargo ck # no need to `cargo ck` because it's already checked in linux
+      - name: Run tests
+        # No need for `cargo ck` because it's already checked in linux
+        # Run `website` tests separately to avoid feature unification problems with `oxlint`
+        run: |
+          cargo test --workspace --all-features --exclude website
+          cargo test -p website
         working-directory: ${{ env.DEV_DRIVE_WORKSPACE }}
         shell: bash
 
@@ -114,7 +122,9 @@ jobs:
           save-cache: ${{ github.ref_name == 'main' }}
           cache-key: s390x-unknown-linux-gnu
           tools: cross
-      - run: cross test --all-features --target s390x-unknown-linux-gnu
+      - run: cross test --workspace --all-features --exclude website --target s390x-unknown-linux-gnu
+      # Run separately to avoid feature unification problems with `oxlint`
+      - run: cross test -p website --target s390x-unknown-linux-gnu
 
   test-wasm32-wasip1-threads:
     name: Test wasm32-wasip1-threads

Cargo.lock

@@ -0,0 +1,3 @@
+node_modules/
+*.node
+dist/

apps/oxlint/.gitignore

@@ -5,6 +5,7 @@ authors.workspace = true
 categories.workspace = true
 edition.workspace = true
 homepage.workspace = true
+include = ["/src", "build.rs"]
 keywords.workspace = true
 license.workspace = true
 publish = false
@@ -16,16 +17,10 @@ description.workspace = true
 workspace = true
 
 [lib]
-crate-type = ["lib"]
+crate-type = ["cdylib", "lib"]
 path = "src/lib.rs"
 doctest = false
 
-[[bin]]
-name = "oxlint"
-path = "src/main.rs"
-test = false
-doctest = false
-
 [dependencies]
 oxc_allocator = { workspace = true, features = ["fixed_size"] }
 oxc_diagnostics = { workspace = true }
@@ -36,13 +31,15 @@ bpaf = { workspace = true, features = ["autocomplete", "bright-color", "derive"]
 cow-utils = { workspace = true }
 ignore = { workspace = true, features = ["simd-accel"] }
 miette = { workspace = true }
-napi = { workspace = true }
+napi = { workspace = true, features = ["async"], optional = true }
+napi-derive = { workspace = true, optional = true }
 rayon = { workspace = true }
 rustc-hash = { workspace = true }
 serde = { workspace = true }
 serde_json = { workspace = true }
 simdutf8 = { workspace = true }
 tempfile = { workspace = true }
+tokio = { workspace = true, features = ["rt-multi-thread"] }
 tracing-subscriber = { workspace = true, features = [] } # Omit the `regex` feature
 
 [target.'cfg(not(any(target_os = "linux", target_os = "freebsd", target_arch = "arm", target_family = "wasm")))'.dependencies]
@@ -54,11 +51,15 @@ mimalloc-safe = { workspace = true, optional = true, features = ["skip_collect_o
 [target.'cfg(all(target_os = "linux", target_arch = "aarch64"))'.dependencies]
 mimalloc-safe = { workspace = true, optional = true, features = ["skip_collect_on_exit", "local_dynamic_tls", "no_opt_arch"] }
 
+[build-dependencies]
+napi-build = { workspace = true }
+
 [dev-dependencies]
 insta = { workspace = true }
 lazy-regex = { workspace = true }
 
 [features]
-default = []
+default = ["napi"]
+napi = ["dep:napi", "dep:napi-derive"]
 allocator = ["dep:mimalloc-safe"]
 force_test_reporter = ["oxc_linter/force_test_reporter"]

apps/oxlint/Cargo.toml

@@ -14,24 +14,28 @@
     "test": "tsc && vitest --dir ./test run"
   },
   "engines": {
-    "node": ">=20.0.0"
+    "node": ">=8.*"
   },
-  "description": "Staging package for oxlint while we integrate custom JS plugins into oxlint",
+  "description": "Linter for the JavaScript Oxidation Compiler",
   "author": "Boshen and oxc contributors",
   "license": "MIT",
   "homepage": "https://oxc.rs",
   "bugs": "https://github.com/oxc-project/oxc/issues",
   "repository": {
     "type": "git",
     "url": "https://github.com/oxc-project/oxc.git",
-    "directory": "napi/oxlint"
+    "directory": "apps/oxlint"
   },
   "publishConfig": {
     "registry": "https://registry.npmjs.org/",
     "access": "public"
   },
   "files": [
-    "dist"
+    "dist",
+    "bin/oxlint",
+    "bin/oxc_language_server",
+    "configuration_schema.json",
+    "README.md"
   ],
   "devDependencies": {
     "execa": "^9.6.0",

napi/oxlint/build.rs apps/oxlint/build.rsnapi/oxlint/build.rs renamed to apps/oxlint/build.rs

@@ -4,13 +4,13 @@ import { join } from 'node:path';
 
 const oxlintDirPath = join(import.meta.dirname, '..'),
   distDirPath = join(oxlintDirPath, 'dist'),
-  parserDirPath = join(oxlintDirPath, '../parser');
+  parserDirPath = join(oxlintDirPath, '../../napi/parser');
 
 // Build with tsdown
 console.log('Building with tsdown...');
 execSync('pnpm tsdown', { stdio: 'inherit', cwd: oxlintDirPath });
 
-// Copy files from `napi/parser` to `napi/oxlint/dist`
+// Copy files from `napi/parser` to `apps/oxlint/dist`
 console.log('Copying files from parser...');
 
 const parserFilePaths = [