perf(lsp): avoid String cloning for fs.get_document

Author: Sysix

crates/oxc_language_server/src/file_system.rs

@@ -1,10 +1,12 @@
+use std::sync::Arc;
+
 use tower_lsp_server::ls_types::Uri;
 
 use crate::{ConcurrentHashMap, LanguageId, TextDocument};
 
 #[derive(Debug, Default)]
 pub struct LSPFileSystem {
-    files: ConcurrentHashMap<Uri, (LanguageId, String)>,
+    files: ConcurrentHashMap<Uri, (LanguageId, Arc<str>)>,
 }
 
 impl LSPFileSystem {
@@ -14,11 +16,11 @@ impl LSPFileSystem {
 
     pub fn set(&self, uri: Uri, content: String) {
         let language_id = self.get_language_id(&uri).unwrap_or_default();
-        self.files.pin().insert(uri, (language_id, content));
+        self.files.pin().insert(uri, (language_id, Arc::from(content)));
     }
 
     pub fn set_with_language(&self, uri: Uri, language_id: LanguageId, content: String) {
-        self.files.pin().insert(uri, (language_id, content));
+        self.files.pin().insert(uri, (language_id, Arc::from(content)));
     }
 
     pub fn get_language_id(&self, uri: &Uri) -> Option<LanguageId> {
@@ -31,7 +33,7 @@ impl LSPFileSystem {
             |(language_id, content)| TextDocument {
                 uri,
                 language_id: language_id.clone(),
-                text: Some(content.clone()),
+                text: Some(Arc::clone(content)),
             },
         )
     }

crates/oxc_language_server/src/lib.rs

@@ -24,11 +24,11 @@ pub type ConcurrentHashMap<K, V> = papaya::HashMap<K, V, FxBuildHasher>;
 pub struct TextDocument<'a> {
     pub uri: &'a Uri,
     pub language_id: LanguageId,
-    pub text: Option<String>,
+    pub text: Option<Arc<str>>,
 }
 
 impl<'a> TextDocument<'a> {
-    pub fn new(uri: &'a Uri, language_id: LanguageId, text: Option<String>) -> Self {
+    pub fn new(uri: &'a Uri, language_id: LanguageId, text: Option<Arc<str>>) -> Self {
         Self { uri, language_id, text }
     }
 }

crates/oxc_language_server/src/worker.rs

@@ -726,7 +726,7 @@ mod tests {
             .run_diagnostic(&TextDocument::new(
                 &uri,
                 LanguageId::default(),
-                Some("helloworld".to_string()),
+                Some(Arc::from("helloworld")),
             ))
             .await
             .unwrap();
@@ -790,7 +790,7 @@ mod tests {
             .run_diagnostic_on_change(&TextDocument::new(
                 &uri,
                 LanguageId::default(),
-                Some("helloworld".to_string()),
+                Some(Arc::from("helloworld")),
             ))
             .await
             .unwrap();
@@ -853,7 +853,7 @@ mod tests {
             .run_diagnostic_on_save(&TextDocument::new(
                 &uri,
                 LanguageId::default(),
-                Some("helloworld".to_string()),
+                Some(Arc::from("helloworld")),
             ))
             .await
             .unwrap();