Add UnaryOp verifier checks

Signed-off-by: Lavanyampalli <lavanyampalli@gmail.com>

Author: Lavanya-Malakalapalli

lib/Dialect/P4HIR/P4HIR_Ops.cpp

@@ -290,12 +290,19 @@ static P4HIR::BinOp getDefiningBinop(P4HIR::BinOpKind kind, mlir::Value val) {
 }
 
 LogicalResult P4HIR::UnaryOp::verify() {
+    auto type = getInput().getType();
+
     switch (getKind()) {
         case P4HIR::UnaryOpKind::Neg:
         case P4HIR::UnaryOpKind::UPlus:
         case P4HIR::UnaryOpKind::Cmpl:
+            if (!mlir::isa<P4HIR::BitsType>(type))
+                return emitOpError("arithmetic and bitwise unary operations require bit or int type");
+            return success();
+
         case P4HIR::UnaryOpKind::LNot:
-            // Nothing to verify.
+            if (!mlir::isa<P4HIR::BoolType>(type))
+                return emitOpError("logical not requires boolean type");
             return success();
     }
 

test/Dialect/P4HIR/unop-errors.mlir

@@ -0,0 +1,13 @@
+// RUN: not p4mlir-opt %s 2>&1 | FileCheck %s --check-prefix=ERR
+
+module {
+  %0 = p4hir.const #p4hir.int<1> : !p4hir.int<8>
+  %1 = p4hir.unary(not, %0) : !p4hir.int<8>
+  // ERR: 'p4hir.unary' op logical not requires boolean type
+}
+
+module {
+  %0 = p4hir.const #p4hir.bool<true> : !p4hir.bool
+  %1 = p4hir.unary(minus, %0) : !p4hir.bool
+  // ERR: 'p4hir.unary' op arithmetic and bitwise unary operations require bit or int type
+}