Skip to content

feat(mock service): add pactfile_write_mode option handling#48

Merged
mefellows merged 1 commit into
pact-foundation:masterfrom
Narazaka:master
May 11, 2017
Merged

feat(mock service): add pactfile_write_mode option handling#48
mefellows merged 1 commit into
pact-foundation:masterfrom
Narazaka:master

Conversation

@Narazaka
Copy link
Copy Markdown
Contributor

@Narazaka Narazaka commented May 9, 2017

I want to use the pactfile_write_mode feature for separated test files.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.05%) to 95.699% when pulling da92274 on Narazaka:master into 5f2c851 on pact-foundation:master.

@mefellows
Copy link
Copy Markdown
Member

This is a great idea!

Have you tested that this gets through to the underlying Ruby process, though (i.e. have you tested this works).

Likely, this would also need to go into http://github.com/pact-foundation/pact-node also, if not into the CLI of the Ruby process.

@Narazaka
Copy link
Copy Markdown
Contributor Author

I had tested it with "overwrite" and "update" option values and checked their working fine. The "pactfile_write_mode" option is handled by not cli options but pact mock server's POST /pact API.
The "smart" option seems to depend on rspec so I ignored that.

@mefellows mefellows merged commit cda7c7f into pact-foundation:master May 11, 2017
@mefellows
Copy link
Copy Markdown
Member

Awesome - I'll bring it in, update the docs etc.

This will be useful for a number of use cases!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants