feat(mock service): add pactfile_write_mode option handling#48
Merged
Conversation
Member
|
This is a great idea! Have you tested that this gets through to the underlying Ruby process, though (i.e. have you tested this works). Likely, this would also need to go into http://github.com/pact-foundation/pact-node also, if not into the CLI of the Ruby process. |
Contributor
Author
|
I had tested it with "overwrite" and "update" option values and checked their working fine. The "pactfile_write_mode" option is handled by not cli options but pact mock server's POST /pact API. |
Member
|
Awesome - I'll bring it in, update the docs etc. This will be useful for a number of use cases! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to use the pactfile_write_mode feature for separated test files.