fix(logging): do not log nil error in run controller (#781)

corrieriluca · web-flow · commit fadf15e1819f · 2025-12-05T18:05:45.000+01:00
diff --git a/internal/controllers/terraformrun/controller.go b/internal/controllers/terraformrun/controller.go
@@ -113,7 +113,7 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Resu
 	}
 	if !bundleOk {
 		r.Recorder.Event(run, corev1.EventTypeWarning, "Reconciliation", fmt.Sprintf("Bundle for revision %s not found in datastore", run.Spec.Layer.Revision))
-		log.Errorf("bundle for revision %s not found in datastore: %s", run.Spec.Layer.Revision, err)
+		log.Errorf("bundle for revision %s not found in datastore", run.Spec.Layer.Revision)
 		return ctrl.Result{RequeueAfter: r.Config.Controller.Timers.OnError}, nil
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Resu`
`113`	`113`	`}`
`114`	`114`	`if !bundleOk {`
`115`	`115`	`r.Recorder.Event(run, corev1.EventTypeWarning, "Reconciliation", fmt.Sprintf("Bundle for revision %s not found in datastore", run.Spec.Layer.Revision))`
`116`		`- log.Errorf("bundle for revision %s not found in datastore: %s", run.Spec.Layer.Revision, err)`
	`116`	`+ log.Errorf("bundle for revision %s not found in datastore", run.Spec.Layer.Revision)`
`117`	`117`	`return ctrl.Result{RequeueAfter: r.Config.Controller.Timers.OnError}, nil`
`118`	`118`	`}`
`119`	`119`