Skip to content

Commit 1803dab

Browse files
committed
statement-store: update prdoc
1 parent 637f1b0 commit 1803dab

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

prdoc/pr_11487.prdoc

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@ doc:
1414
`was_major_syncing → false` transition drains the buffer: all deferred peers are added to
1515
the reserved set in a single call, their notification substreams open, and each peer
1616
performs a fresh initial sync that delivers the statements missed during sync.
17-
18-
No `remove_peers_from_reserved_set` is called, eliminating the 5-second reconnect backoff
19-
and peerset races that the previous `remove+add` approach introduced.
2017
crates:
2118
- name: sc-network-statement
2219
bump: patch

substrate/client/network/statement/src/lib.rs

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1597,7 +1597,7 @@ mod tests {
15971597
}
15981598

15991599
fn is_offline(&self) -> bool {
1600-
false
1600+
unimplemented!()
16011601
}
16021602
}
16031603

@@ -3927,7 +3927,7 @@ mod tests {
39273927
network.get_removed_reserved().is_empty(),
39283928
"remove_peers_from_reserved_set must not be called during major sync",
39293929
);
3930-
assert_eq!(handler.deferred_peers.len(), 3, "All three peers should be in deferred_peers");
3930+
assert_eq!(handler.deferred_peers.len(), 3);
39313931
assert!(handler.deferred_peers.contains(&peer1));
39323932
assert!(handler.deferred_peers.contains(&peer2));
39333933
assert!(handler.deferred_peers.contains(&peer3));
@@ -3980,7 +3980,7 @@ mod tests {
39803980
assert!(handler.deferred_peers.is_empty());
39813981

39823982
let added = network.get_added_reserved();
3983-
assert_eq!(added.len(), 1, "Expected exactly one add_peers_to_reserved_set call");
3983+
assert_eq!(added.len(), 1);
39843984
let added_addrs = &added[0];
39853985
let expected_addr1: sc_network::Multiaddr =
39863986
iter::once(multiaddr::Protocol::P2p(peer1.into())).collect();
@@ -3989,10 +3989,7 @@ mod tests {
39893989
assert!(added_addrs.contains(&expected_addr1), "peer1 must be in added set");
39903990
assert!(added_addrs.contains(&expected_addr2), "peer2 must be in added set");
39913991

3992-
assert!(
3993-
network.get_removed_reserved().is_empty(),
3994-
"remove_peers_from_reserved_set must never be called by the buffer approach",
3995-
);
3992+
assert!(network.get_removed_reserved().is_empty());
39963993
}
39973994

39983995
#[test]

0 commit comments

Comments
 (0)