Merge remote-tracking branch 'origin/stable2512' into sigurpol-staking-async-rc-client-proof-in-set-keys-no-op-validation

Author: sigurpol

Cargo.lock

@@ -910,7 +910,7 @@ linked-hash-map = { version = "0.5.4" }
 linked_hash_set = { version = "0.1.4" }
 linregress = { version = "0.5.1" }
 lite-json = { version = "0.2.0", default-features = false }
-litep2p = { version = "0.13.0", features = ["rsa", "websocket"] }
+litep2p = { version = "0.13.2", features = ["rsa", "websocket"] }
 log = { version = "0.4.22", default-features = false }
 macro_magic = { version = "0.5.1" }
 maplit = { version = "1.0.2" }

Cargo.toml

@@ -1,5 +1,5 @@
 # generated by parity-publish v0.10.10
-# command: parity-publish plan --prdoc prdoc
+# command: parity-publish plan --prdoc prdoc/pr_11197.prdoc
 
 [options]
 
@@ -1458,9 +1458,9 @@ reason = "changed"
 [[crate]]
 # substrate/frame/election-provider-multi-block
 name = "pallet-election-provider-multi-block"
-from = "0.5.0"
-to = "0.6.0"
-bump = "major"
+from = "0.6.0"
+to = "0.6.1"
+bump = "patch"
 reason = "changed"
 
 [[crate]]
@@ -2014,8 +2014,8 @@ reason = "changed"
 [[crate]]
 # substrate/frame/session
 name = "pallet-session"
-from = "45.0.0"
-to = "45.1.0"
+from = "45.1.0"
+to = "45.2.0"
 bump = "minor"
 reason = "changed"
 
@@ -2414,8 +2414,8 @@ reason = "changed"
 [[crate]]
 # substrate/frame/staking-async/rc-client
 name = "pallet-staking-async-rc-client"
-from = "0.7.0"
-to = "0.7.1"
+from = "0.7.1"
+to = "0.7.2"
 bump = "minor"
 reason = "changed"
 
@@ -2692,9 +2692,9 @@ reason = "changed"
 [[crate]]
 # substrate/frame/staking-async
 name = "pallet-staking-async"
-from = "0.10.0"
-to = "0.10.1"
-bump = "patch"
+from = "0.10.1"
+to = "0.10.2"
+bump = "minor"
 reason = "changed"
 
 [[crate]]
@@ -3500,9 +3500,9 @@ reason = "changed"
 [[crate]]
 # cumulus/parachains/runtimes/assets/asset-hub-westend
 name = "asset-hub-westend-runtime"
-from = "0.40.0"
-to = "0.42.0"
-bump = "major"
+from = "0.42.0"
+to = "0.42.1"
+bump = "minor"
 reason = "changed"
 
 [[crate]]

Plan.toml

@@ -1,6 +1,6 @@
 [package]
 name = "asset-hub-westend-runtime"
-version = "0.42.0"
+version = "0.42.1"
 authors.workspace = true
 edition.workspace = true
 description = "Westend variant of Asset Hub parachain runtime"

cumulus/parachains/runtimes/assets/asset-hub-westend/Cargo.toml

@@ -331,7 +331,8 @@ impl pallet_staking_async_rc_client::Config for Runtime {
 	// export validator session at end of session 4 within an era.
 	type ValidatorSetExportSession = ConstU32<4>;
 	type RelayChainSessionKeys = RelayChainSessionKeys;
-	type Balance = Balance;
+	type Currency = Balances;
+	type KeyDeposit = ConstU128<{ 10 * UNITS }>;
 	// | Key                 | Crypto  | Public Key | Signature |
 	// |---------------------|---------|------------|-----------|
 	// | grandpa             | Ed25519 | 32 bytes   | 64 bytes  |
@@ -342,7 +343,6 @@ impl pallet_staking_async_rc_client::Config for Runtime {
 	// | beefy               | ECDSA   | 33 bytes   | 65 bytes  |
 	// | Total               |         | 193 bytes  | 385 bytes |
 	// We add some buffer for SCALE encoding overhead and future expansions
-	type MaxSessionKeysLength = ConstU32<256>;
 	type WeightInfo = weights::pallet_staking_async_rc_client::WeightInfo<Runtime>;
 }
 

cumulus/parachains/runtimes/assets/asset-hub-westend/src/staking.rs

@@ -0,0 +1,21 @@
+title: 'net: Strip previous p2p prefix before concatenating addresses'
+doc:
+- audience: Node Dev
+  description: |-
+    This PR ensures that a `MultiaddrWithPeerId` will always remain valid after a concatenating process.
+
+    The litep2p code will concatanate the provided multiaddr-with-peerID regardless if the address already contains a `p2p/..` prefix:
+
+    https://github.com/paritytech/polkadot-sdk/blob/e85be1c07adedcc86554affa4f6af536c4a2efc1/substrate/client/network/src/litep2p/service.rs#L427-L434
+
+
+    This then can lead to addresses for reserved peers to never be dialed by the network backend as they are considered invalid.
+
+    This has been discovered by running the networking benchmarks:
+    https://github.com/paritytech/polkadot-sdk/blob/e85be1c07adedcc86554affa4f6af536c4a2efc1/substrate/client/network/benches/notifications_protocol.rs#L143-L148
+
+    Part of the cleanups for:
+    - https://github.com/paritytech/polkadot-sdk/issues/10425
+crates:
+- name: sc-network
+  bump: patch

prdoc/pr_11078.prdoc

@@ -0,0 +1,14 @@
+title: Upgrade litep2p v0.13.0 -> v0.13.1
+doc:
+- audience: Node Dev
+  description: |-
+    This PR brings litep2p v0.13.1 to polkadot-sdk. The improvements include:
+
+    1. When dialing remote peers, all addresses from the DHT are tried, starting from the public addresses. Before litep2p v0.13.1, only up to 8 addresses were tried, leading to dial failures when due to misconfiguration there was a lot of private addresses in the DHT.
+    2. Protocols are now notified about connected peers before the library user, fixing failures in opening substreams when the user command arrived before the connection event.
+    3. Ping protocol implementation now conforms to the spec. This improves the connection stability between polkadot-sdk and [smoldot](https://github.com/smol-dot/smoldot) dramatically. Before this PR, smoldot always disconnected polkadot-sdk peers every 15 seconds for 5 seconds due to failed pings.
+crates:
+- name: sc-network
+  bump: minor
+- name: sc-network-types
+  bump: minor

prdoc/pr_11204.prdoc

@@ -0,0 +1,15 @@
+title: 'staking-async/rc-client: replace MinSetKeysBond with storage deposit'
+doc:
+- audience: Runtime Dev
+  description: "Replace MinSetKeysBond with a fungible hold deposit (KeyDeposit) which\
+    \ ties the cost directly to the storage used: held on set_keys, released on purge_keys.\n\
+    Idempotency is checked by inspecting the existing hold balance rather than a\
+    \ separate storage map. Existing validators are charged on next set_keys."
+crates:
+- name: asset-hub-westend-runtime
+  bump: minor
+  validate: false
+- name: pallet-staking-async-rc-client
+  bump: minor
+- name: pallet-staking-async
+  bump: minor

prdoc/pr_11222.prdoc

@@ -0,0 +1,16 @@
+title: Add MinSetKeysBond check in rc_client::set_keys
+doc:
+- audience: Runtime Dev
+  description: |-
+   Add a configurable MinSetKeysBond threshold (hardcoded to 10 WND on asset-hub-westend) that rejects set_keys when active bond
+   is insufficient. Set to 0 to disable.
+crates:
+- name: asset-hub-westend-runtime
+  bump: minor
+  validate: false
+- name: pallet-staking-async-rc-client
+  bump: minor
+  validate: false
+- name: pallet-staking-async
+  bump: minor
+  validate: false