cleanup todos with tracking issues (#996)

Author: niklasad1

src/commands/types.rs

@@ -169,7 +169,7 @@ pub struct MonitorConfig {
     pub dry_run: bool,
 }
 
-/// TODO(niklasad1): Add solver algorithm configuration to the monitor command.
+/// TODO: make `solver algorithm` configurable https://github.com/paritytech/polkadot-staking-miner/issues/989
 #[derive(Debug, Clone, clap::Parser)]
 #[cfg_attr(test, derive(PartialEq))]
 pub struct ExperimentalMultiBlockMonitorConfig {

src/dynamic/multi_block.rs

@@ -216,7 +216,7 @@ where
         all_targets: target_snapshot.clone(),
         voter_pages: voter_pages.clone(),
         pages: n_pages,
-        // TODO: get from runtime/configs.
+        // TODO: https://github.com/paritytech/polkadot-staking-miner/issues/995
         do_reduce: false,
         round,
     };

src/static_types/multi_block.rs

@@ -18,30 +18,30 @@ impl_u32_parameter_type!(max_length, MaxLength);
 pub mod node {
     use super::*;
 
+    // TODO: validate config https://github.com/paritytech/polkadot-staking-miner/issues/994
     frame_election_provider_support::generate_solution_type!(
         #[compact]
         pub struct NposSolution16::<
             VoterIndex = u16,
             TargetIndex = u16,
             Accuracy = Percent,
-            MaxVoters = ConstU32::<22500> // TODO: fetch
+            MaxVoters = ConstU32::<22500>
         >(16)
     );
 
     #[derive(Debug)]
     pub struct MinerConfig;
 
+    // TODO: validate config https://github.com/paritytech/polkadot-staking-miner/issues/994
     impl multi_block::unsigned::miner::MinerConfig for MinerConfig {
         type AccountId = AccountId;
         type Solution = NposSolution16;
-        // TODO: make it configurable via CLI/data from the node.
+        // TODO: make it configurable via CLI https://github.com/paritytech/polkadot-staking-miner/issues/989
         type Solver = SequentialPhragmen<AccountId, Accuracy>;
         type Pages = Pages;
-        // TODO: make it configurable via CLI/data from the node.
         type MaxVotesPerVoter = ConstU32<16>;
         type MaxWinnersPerPage = MaxWinnersPerPage;
         type MaxBackersPerWinner = MaxBackersPerWinner;
-        // TODO: make it configurable via CLI/data from the node.
         type MaxBackersPerWinnerFinal = ConstU32<{ u32::MAX }>;
         type VoterSnapshotPerBlock = VoterSnapshotPerBlock;
         type TargetSnapshotPerBlock = TargetSnapshotPerBlock;
@@ -54,31 +54,30 @@ pub mod polkadot {
     use super::*;
     use frame_election_provider_support::SequentialPhragmen;
 
-    // TODO: not tested, not sure whether the accuracy will be changed to percent as well.
+    // TODO: validate config https://github.com/paritytech/polkadot-staking-miner/issues/994
     frame_election_provider_support::generate_solution_type!(
         #[compact]
         pub struct NposSolution16::<
             VoterIndex = u32,
             TargetIndex = u16,
             Accuracy = PerU16,
-            MaxVoters = ConstU32::<22500> // TODO: fetch
+            MaxVoters = ConstU32::<22500>
         >(16)
     );
 
     #[derive(Debug)]
     pub struct MinerConfig;
 
+    // TODO: validate config https://github.com/paritytech/polkadot-staking-miner/issues/994
     impl multi_block::unsigned::miner::MinerConfig for MinerConfig {
         type AccountId = AccountId;
         type Solution = NposSolution16;
-        // TODO: make it configurable via CLI/data from the node.
+        // TODO: make it configurable via CLI https://github.com/paritytech/polkadot-staking-miner/issues/989
         type Solver = SequentialPhragmen<AccountId, Accuracy>;
         type Pages = Pages;
-        // TODO: make it configurable via CLI/data from the node.
         type MaxVotesPerVoter = ConstU32<16>;
         type MaxWinnersPerPage = MaxWinnersPerPage;
         type MaxBackersPerWinner = MaxBackersPerWinner;
-        // TODO: make it configurable via CLI/data from the node.
         type MaxBackersPerWinnerFinal = ConstU32<{ u32::MAX }>;
         type VoterSnapshotPerBlock = VoterSnapshotPerBlock;
         type TargetSnapshotPerBlock = TargetSnapshotPerBlock;
@@ -91,31 +90,30 @@ pub mod kusama {
     use super::*;
     use frame_election_provider_support::SequentialPhragmen;
 
-    // TODO: not tested, not sure whether the accuracy will be changed to percent as well.
+    // TODO: validate config https://github.com/paritytech/polkadot-staking-miner/issues/994
     frame_election_provider_support::generate_solution_type!(
         #[compact]
         pub struct NposSolution24::<
             VoterIndex = u32,
             TargetIndex = u16,
             Accuracy = PerU16,
-            MaxVoters = ConstU32::<12500> // TODO: fetch/validate
+            MaxVoters = ConstU32::<12500>
         >(24)
     );
 
     #[derive(Debug)]
     pub struct MinerConfig;
 
+    // TODO: validate config https://github.com/paritytech/polkadot-staking-miner/issues/994
     impl multi_block::unsigned::miner::MinerConfig for MinerConfig {
         type AccountId = AccountId;
         type Solution = NposSolution24;
-        // TODO: make it configurable via CLI/data from the node.
+        // TODO: make it configurable via CLI https://github.com/paritytech/polkadot-staking-miner/issues/989
         type Solver = SequentialPhragmen<AccountId, Accuracy>;
         type Pages = Pages;
-        // TODO: make it configurable via CLI/data from the node.
         type MaxVotesPerVoter = ConstU32<24>;
         type MaxWinnersPerPage = MaxWinnersPerPage;
         type MaxBackersPerWinner = MaxBackersPerWinner;
-        // TODO: make it configurable via CLI/data from the node.
         type MaxBackersPerWinnerFinal = ConstU32<{ u32::MAX }>;
         type VoterSnapshotPerBlock = VoterSnapshotPerBlock;
         type TargetSnapshotPerBlock = TargetSnapshotPerBlock;
@@ -128,31 +126,30 @@ pub mod westend {
     use super::*;
     use frame_election_provider_support::SequentialPhragmen;
 
-    // TODO: not tested, not sure whether the accuracy will be changed to percent as well.
+    // TODO: validate config https://github.com/paritytech/polkadot-staking-miner/issues/994
     frame_election_provider_support::generate_solution_type!(
         #[compact]
         pub struct NposSolution16::<
             VoterIndex = u32,
             TargetIndex = u16,
             Accuracy = PerU16,
-            MaxVoters = ConstU32::<22500> // TODO: fetch/validate
+            MaxVoters = ConstU32::<22500>
         >(16)
     );
 
     #[derive(Debug)]
     pub struct MinerConfig;
 
+    // TODO: validate config https://github.com/paritytech/polkadot-staking-miner/issues/994
     impl multi_block::unsigned::miner::MinerConfig for MinerConfig {
         type AccountId = AccountId;
         type Solution = NposSolution16;
-        // TODO: make it configurable via CLI/data from the node.
+        // TODO: make it configurable via CLI https://github.com/paritytech/polkadot-staking-miner/issues/989
         type Solver = SequentialPhragmen<AccountId, Accuracy>;
         type Pages = Pages;
-        // TODO: make it configurable via CLI/data from the node.
         type MaxVotesPerVoter = ConstU32<16>;
         type MaxWinnersPerPage = MaxWinnersPerPage;
         type MaxBackersPerWinner = MaxBackersPerWinner;
-        // TODO: make it configurable via CLI/data from the node.
         type MaxBackersPerWinnerFinal = ConstU32<{ u32::MAX }>;
         type VoterSnapshotPerBlock = VoterSnapshotPerBlock;
         type TargetSnapshotPerBlock = TargetSnapshotPerBlock;