fix: --listen finalized wait for finalized xt#425
Merged
Conversation
niklasad1
commented
Dec 1, 2022
kianenigma
reviewed
Dec 5, 2022
| @@ -448,11 +456,13 @@ async fn submit_and_watch_solution<T: MinerConfig + Send + Sync + 'static>( | |||
| .find_first::<runtime::election_provider_multi_phase::events::SolutionStored>( | |||
| ); | |||
Contributor
There was a problem hiding this comment.
formatting seems broken here?
Contributor
Author
There was a problem hiding this comment.
rustfmt wants it like that 😭
kianenigma
approved these changes
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When one runs
--listen finalizedit's possible for the block not to be finalized when it's included in block.Thus, when that task finishes it's possible to that the
next taskwill not see that submission as it is not finalized yet and submit more than one submission in a round.Should fix the duplicate solutions that I spotted on westend.