Conversation
niklasad1
commented
Apr 26, 2023
niklasad1
commented
Apr 26, 2023
niklasad1
commented
Apr 26, 2023
jsdw
reviewed
Apr 26, 2023
Contributor
|
Looks mostly good, thanks! |
niklasad1
commented
May 8, 2023
niklasad1
commented
May 9, 2023
…into na-staking-miner-trimming-test
gpestana
suggested changes
May 17, 2023
Contributor
gpestana
left a comment
gpestana
left a comment
There was a problem hiding this comment.
Added a few comments and questions. Also I don't see to be able to build and run the tests for staking-miner-playground locally, the compilation is failing.
| assert!(success); | ||
| assert!(got_truncate_weight, "Trimming weight logs were not found"); | ||
| assert!(got_truncate_len, "Trimming length logs were not found"); | ||
|
|
Contributor
There was a problem hiding this comment.
Would it be possible to assert how much has been truncated in terms of len and weight, or are those values not deterministic?
Contributor
Author
There was a problem hiding this comment.
Those are not deterministic right now, I guess it's because how the nominators are generated with some randomness so the number of assignments differ between the runs.
Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com>
…into na-staking-miner-trimming-test
niklasad1
commented
May 18, 2023
Contributor
Author
|
merging this now, because I want to run it our daily integration tests. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically it works like this:
For instance recall that Kian added some special code where the number of validators, nominators etc can be configured by env variables and we read the same env variables to ensure that MaxLength is less than the number of validators.
a) Trimming weight and length from the CLI output isn't 0
b) the solution is accepted by chain (hence feasibility check was successful)