Conversation
kianenigma
approved these changes
May 7, 2023
Ank4n
reviewed
May 7, 2023
Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com>
niklasad1
reviewed
May 8, 2023
niklasad1
reviewed
May 8, 2023
Contributor
niklasad1
left a comment
niklasad1
left a comment
There was a problem hiding this comment.
looks good,
just one thing regarding metadata on MaxWinners
niklasad1
reviewed
May 21, 2023
| const MAX_LENGTH: EpmConstant = EpmConstant::new("MinerMaxLength"); | ||
| const MAX_VOTES_PER_VOTER: EpmConstant = EpmConstant::new("MinerMaxVotesPerVoter"); | ||
| const MAX_WINNERS: EpmConstant = EpmConstant::new("MinerMaxWinners"); | ||
| const MAX_WINNERS: EpmConstant = EpmConstant::new("MaxWinners"); |
Contributor
There was a problem hiding this comment.
Ok, this was set to work with older metadata right?
Smart move as this is just duplicated in the MinerConfig :P
Contributor
There was a problem hiding this comment.
Maybe add a comment for that :)
niklasad1
approved these changes
May 21, 2023
Ank4n
approved these changes
May 21, 2023
niklasad1
reviewed
May 23, 2023
niklasad1
reviewed
May 23, 2023
niklasad1
reviewed
May 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the
emergency_solution_cmd, similar to the staking-miner-v1 implementation. In addition, it saves the encodedset_emergency_solutionEPM call into a file for easy handling.