chore: update deps to publish on crates.io#715
Merged
Conversation
niklasad1
commented
Nov 22, 2023
niklasad1
changed the title
niklasad1
commented
Nov 23, 2023
Contributor
Author
There was a problem hiding this comment.
I was forced to update the metadata for the codegen to work
There was a problem hiding this comment.
Hmm interesting, might be worth a subxt issue probably we'd want to keep backwards compatibility between 14 and 15 versions 🤔
Contributor
Author
There was a problem hiding this comment.
I decided not to trim the metadata because of paritytech/subxt#1286
lexnv
approved these changes
Nov 23, 2023
niklasad1
commented
Nov 23, 2023
| use subxt::backend::rpc::RpcClient as RawRpcClient; | ||
|
|
||
| /// Wraps the subxt interfaces to make it easy to use for the staking-miner. | ||
| #[derive(Clone, Debug)] |
Contributor
Author
There was a problem hiding this comment.
subxt's APIs has been modified a bit, thus this type is introduced to provide a wrapper for the APIs that the staking miner needs.
gpestana
approved these changes
Nov 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparation for a new release which mainly updates subxt and jsonrpsee.
One nice thing is that default port number in the URI can be omitted now