Fix: Feasibility check fails when all voters have the same staked amount#856
Merged
niklasad1 merged 1 commit intoparitytech:mainfrom Jul 1, 2024
Merged
Conversation
`TrimmedVotes` uses `BTreeMap` to sort voters by stake, which results in voters with the same stake to be dropped from election. In case if `desired_targets` == `total_voters` it results in immediate feasibility check failure in `solution_weight`->`epm::mock_votes`, as `voters < desired_targets`.
niklasad1
approved these changes
Jun 28, 2024
Contributor
niklasad1
left a comment
niklasad1
left a comment
There was a problem hiding this comment.
nice catch, looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TrimmedVotesusesBTreeMapto sort voters by stake, which results in voters with the same stake to be dropped from election.In case if
desired_targets==total_voters(on private network) it results in immediate feasibility check failure insolution_weight->epm::mock_votes, asvoters < desired_targets.