Error when parsing an empty key

pelletier · pelletier · commit fa1c2ab68c09 · 2015-12-01T14:02:02.000+01:00
diff --git a/keysparsing.go b/keysparsing.go
@@ -70,6 +70,9 @@ func parseKey(key string) ([]string, error) {
 	if buffer.Len() > 0 {
 		groups = append(groups, buffer.String())
 	}
+	if len(groups) == 0 {
+		return nil, fmt.Errorf("empty key")
+	}
 	return groups, nil
 }
 
diff --git a/keysparsing_test.go b/keysparsing_test.go
@@ -42,3 +42,8 @@ func TestDottedKeyBasic(t *testing.T) {
 func TestBaseKeyPound(t *testing.T) {
 	testError(t, "hello#world", "invalid bare character: #")
 }
+
+func TestEmptyKey(t *testing.T) {
+	testError(t, "", "empty key")
+	testError(t, " ", "empty key")
+}

Original file line number	Diff line number	Diff line change
`@@ -70,6 +70,9 @@ func parseKey(key string) ([]string, error) {`
`70`	`70`	`if buffer.Len() > 0 {`
`71`	`71`	`groups = append(groups, buffer.String())`
`72`	`72`	`}`
	`73`	`+ if len(groups) == 0 {`
	`74`	`+ return nil, fmt.Errorf("empty key")`
	`75`	`+ }`
`73`	`76`	`return groups, nil`
`74`	`77`	`}`
`75`	`78`
Original file line number	Diff line number	Diff line change
`@@ -42,3 +42,8 @@ func TestDottedKeyBasic(t *testing.T) {`
`42`	`42`	`func TestBaseKeyPound(t *testing.T) {`
`43`	`43`	`testError(t, "hello#world", "invalid bare character: #")`
`44`	`44`	`}`
	`45`	`+`
	`46`	`+func TestEmptyKey(t *testing.T) {`
	`47`	`+ testError(t, "", "empty key")`
	`48`	`+ testError(t, " ", "empty key")`
	`49`	`+}`