Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit c7dc4b1

Browse files
committedJul 10, 2022
refactor: remove imports of no longer needed property files from unit tests
We don't need to import queries as now they are imported by related configuration classes. See commits: 26c9f9f and e4fa25a Fix #1151
1 parent 85f46f0 commit c7dc4b1

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed
 

‎src/test/java/ru/mystamps/web/feature/category/JdbcCategoryDaoTest.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,7 @@
4040
// overrides settings from application-test.properties to keep the console clean,
4141
// comment this out when you need to debug tests. See also logback-test.xml
4242
"logging.level.root=WARN", "logging.level.ru.mystamps=WARN"
43-
},
44-
// @todo #1143 Improve a way of importing properties files in the tests
45-
locations = "/sql/category_dao_queries.properties")
43+
})
4644
@ExtendWith(SpringExtension.class)
4745
public class JdbcCategoryDaoTest implements WithAssertions {
4846

‎src/test/java/ru/mystamps/web/feature/country/JdbcCountryDaoTest.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,7 @@
4040
// overrides settings from application-test.properties to keep the console clean,
4141
// comment this out when you need to debug tests. See also logback-test.xml
4242
"logging.level.root=WARN", "logging.level.ru.mystamps=WARN"
43-
},
44-
// LATER: find a better way for importing properties files (see #1151)
45-
locations = "/sql/country_dao_queries.properties")
43+
})
4644
@ExtendWith(SpringExtension.class)
4745
public class JdbcCountryDaoTest implements WithAssertions {
4846

0 commit comments

Comments
 (0)
Please sign in to comment.