Use ZVAL_NEW_STR() for new string in php_filter_encode_html()

nielsdos · nielsdos · commit 31b4f39d3edb · 2025-06-09T11:12:17.000+02:00
diff --git a/ext/filter/sanitizing_filters.c b/ext/filter/sanitizing_filters.c
@@ -49,7 +49,7 @@ static void php_filter_encode_html(zval *value, const unsigned char *chars)
 	}
 
 	zval_ptr_dtor(value);
-	ZVAL_STR(value, smart_str_extract(&str));
+	ZVAL_NEW_STR(value, smart_str_extract(&str));
 }
 
 static const unsigned char hexchars[] = "0123456789ABCDEF";

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ static void php_filter_encode_html(zval value, const unsigned char chars)`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`zval_ptr_dtor(value);`
`52`		`- ZVAL_STR(value, smart_str_extract(&str));`
	`52`	`+ ZVAL_NEW_STR(value, smart_str_extract(&str));`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`static const unsigned char hexchars[] = "0123456789ABCDEF";`