Intl: Fix compile issues with ICU versions lower than 67

[BogdanUngureanu]

fixes #18860

It gets built, but I'm having some environment issues with setting up ICU 63, so I haven't actually run the tests to see if it's working.

When PHP intl is built with an older version of ICU (66 or older), we need a fallback for the AND and WIDE parameters. To solve this, I've added INTL_LISTFORMATTER_FALLBACK_TYPE_AND and INTL_LISTFORMATTER_FALLBACK_WIDTH_WIDE.

I've ran it locally with ICU 63 and the change works as expected (the tests pass). There's a failing test related to currencies, but it's unrelated to this change (some CLDR differences between versions).

cc @SjonHortensius

[BogdanUngureanu]

@devnexen if you have some spare time, it would be great if you could have a look.

[devnexen]

looks fine, did you need that change though ?

[BogdanUngureanu]

yes, that's needed because the stub contains references to the fallbacks. listformatter_arginfo.h needs to be after.

Otherwise it would fail with

php-src/ext/intl/listformatter/listformatter_arginfo.h:50:35: error: use of undeclared identifier 'INTL_LISTFORMATTER_FALLBACK_TYPE_AND'

[devnexen]

Thanks for fixing it promptly !

[nielsdos]

Does this fix make sense? If you're on an older version the constants are set to 0. Normally, when functionality is not available, we don't expose the constant at all. Diverging from this is confusing imo.

[BogdanUngureanu]

I think it does because it makes the public contract consistent for the constructor. Otherwise, consumers will not know what values the constructor accepts for type and width.

If we didn't have the TYPE_AND and WIDE fallbacks, we would have 2 options:

• have different arguments for the constructor depending on the ICU version - that would make it confusing and inconsistent
• have the same signature for it, but don't have any error validation if they pass invalid data (e.g. TYPE_OR or a random value) - that would not inform the consumers that the formatting won't work as they expect it will work, it will always format with AND and WIDE.

[nielsdos]

Okay I agree