Added tests for ToMany relations

Author: lookyman

tests/Rules/Doctrine/ORM/EntityRelationRuleTest.php

@@ -66,6 +66,44 @@ public function ruleProvider(): Iterator
 				50,
 			]
 		]];
+
+		yield 'one to many' => [__DIR__ . '/data/EntityWithBrokenOneToManyRelations.php', [
+			[
+				'Property can contain iterable<PHPStan\Rules\Doctrine\ORM\AnotherEntity> but database expects Doctrine\Common\Collections\Collection&iterable<PHPStan\Rules\Doctrine\ORM\AnotherEntity>.',
+				24,
+			],
+			[
+				'Property can contain Doctrine\Common\Collections\Collection but database expects Doctrine\Common\Collections\Collection&iterable<PHPStan\Rules\Doctrine\ORM\AnotherEntity>.',
+				30,
+			],
+			[
+				'Database can contain Doctrine\Common\Collections\Collection&iterable<PHPStan\Rules\Doctrine\ORM\AnotherEntity> but property expects array<PHPStan\Rules\Doctrine\ORM\AnotherEntity>.',
+				36,
+			],
+			[
+				'Property can contain array<PHPStan\Rules\Doctrine\ORM\AnotherEntity> but database expects Doctrine\Common\Collections\Collection&iterable<PHPStan\Rules\Doctrine\ORM\AnotherEntity>.',
+				36,
+			]
+		]];
+
+		yield 'many to many' => [__DIR__ . '/data/EntityWithBrokenManyToManyRelations.php', [
+			[
+				'Property can contain iterable<PHPStan\Rules\Doctrine\ORM\AnotherEntity> but database expects Doctrine\Common\Collections\Collection&iterable<PHPStan\Rules\Doctrine\ORM\AnotherEntity>.',
+				24,
+			],
+			[
+				'Property can contain Doctrine\Common\Collections\Collection but database expects Doctrine\Common\Collections\Collection&iterable<PHPStan\Rules\Doctrine\ORM\AnotherEntity>.',
+				30,
+			],
+			[
+				'Database can contain Doctrine\Common\Collections\Collection&iterable<PHPStan\Rules\Doctrine\ORM\AnotherEntity> but property expects array<PHPStan\Rules\Doctrine\ORM\AnotherEntity>.',
+				36,
+			],
+			[
+				'Property can contain array<PHPStan\Rules\Doctrine\ORM\AnotherEntity> but database expects Doctrine\Common\Collections\Collection&iterable<PHPStan\Rules\Doctrine\ORM\AnotherEntity>.',
+				36,
+			]
+		]];
 	}
 
 }

tests/Rules/Doctrine/ORM/data/AnotherEntity.php

@@ -22,4 +22,29 @@ class AnotherEntity
 	 */
 	private $manyToOne;
 
+	/**
+	 * @ORM\ManyToOne(targetEntity="PHPStan\Rules\Doctrine\ORM\EntityWithBrokenOneToManyRelations")
+	 */
+	private $one;
+
+	/**
+	 * @ORM\ManyToOne(targetEntity="PHPStan\Rules\Doctrine\ORM\EntityWithBrokenOneToManyRelations")
+	 */
+	private $two;
+
+	/**
+	 * @ORM\ManyToOne(targetEntity="PHPStan\Rules\Doctrine\ORM\EntityWithBrokenOneToManyRelations")
+	 */
+	private $three;
+
+	/**
+	 * @ORM\ManyToOne(targetEntity="PHPStan\Rules\Doctrine\ORM\EntityWithBrokenOneToManyRelations")
+	 */
+	private $four;
+
+	/**
+	 * @ORM\ManyToOne(targetEntity="PHPStan\Rules\Doctrine\ORM\EntityWithBrokenOneToManyRelations")
+	 */
+	private $five;
+
 }

tests/Rules/Doctrine/ORM/data/EntityWithBrokenManyToManyRelations.php

@@ -0,0 +1,50 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Doctrine\ORM;
+
+use Doctrine\ORM\Mapping as ORM;
+
+/**
+ * @ORM\Entity()
+ */
+class EntityWithBrokenManyToManyRelations
+{
+
+	/**
+	 * @ORM\Id()
+	 * @ORM\Column(type="int")
+	 * @var int
+	 */
+	private $id;
+
+	/**
+	 * @ORM\ManyToMany(targetEntity="PHPStan\Rules\Doctrine\ORM\AnotherEntity")
+	 * @var iterable<\PHPStan\Rules\Doctrine\ORM\AnotherEntity>
+	 */
+	private $manyToManyWithIterableAnnotation;
+
+	/**
+	 * @ORM\ManyToMany(targetEntity="PHPStan\Rules\Doctrine\ORM\AnotherEntity")
+	 * @var \Doctrine\Common\Collections\Collection
+	 */
+	private $manyToManyWithCollectionAnnotation;
+
+	/**
+	 * @ORM\ManyToMany(targetEntity="PHPStan\Rules\Doctrine\ORM\AnotherEntity")
+	 * @var \PHPStan\Rules\Doctrine\ORM\AnotherEntity[]
+	 */
+	private $manyToManyWithArrayAnnotation;
+
+	/**
+	 * @ORM\ManyToMany(targetEntity="PHPStan\Rules\Doctrine\ORM\AnotherEntity")
+	 * @var \Doctrine\Common\Collections\Collection&iterable<\PHPStan\Rules\Doctrine\ORM\AnotherEntity>
+	 */
+	private $manyToManyWithCorrectAnnotation;
+
+	/**
+	 * @ORM\ManyToMany(targetEntity="PHPStan\Rules\Doctrine\ORM\AnotherEntity")
+	 * @var \Doctrine\Common\Collections\Collection|\PHPStan\Rules\Doctrine\ORM\AnotherEntity[]
+	 */
+	private $manyToManyWithCorrectOldStyleAnnotation;
+
+}

tests/Rules/Doctrine/ORM/data/EntityWithBrokenOneToManyRelations.php

@@ -0,0 +1,50 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Doctrine\ORM;
+
+use Doctrine\ORM\Mapping as ORM;
+
+/**
+ * @ORM\Entity()
+ */
+class EntityWithBrokenOneToManyRelations
+{
+
+	/**
+	 * @ORM\Id()
+	 * @ORM\Column(type="int")
+	 * @var int
+	 */
+	private $id;
+
+	/**
+	 * @ORM\OneToMany(targetEntity="PHPStan\Rules\Doctrine\ORM\AnotherEntity", mappedBy="one")
+	 * @var iterable<\PHPStan\Rules\Doctrine\ORM\AnotherEntity>
+	 */
+	private $oneToManyWithIterableAnnotation;
+
+	/**
+	 * @ORM\OneToMany(targetEntity="PHPStan\Rules\Doctrine\ORM\AnotherEntity", mappedBy="two")
+	 * @var \Doctrine\Common\Collections\Collection
+	 */
+	private $oneToManyWithCollectionAnnotation;
+
+	/**
+	 * @ORM\OneToMany(targetEntity="PHPStan\Rules\Doctrine\ORM\AnotherEntity", mappedBy="three")
+	 * @var \PHPStan\Rules\Doctrine\ORM\AnotherEntity[]
+	 */
+	private $oneToManyWithArrayAnnotation;
+
+	/**
+	 * @ORM\OneToMany(targetEntity="PHPStan\Rules\Doctrine\ORM\AnotherEntity", mappedBy="four")
+	 * @var \Doctrine\Common\Collections\Collection&iterable<\PHPStan\Rules\Doctrine\ORM\AnotherEntity>
+	 */
+	private $oneToManyWithCorrectAnnotation;
+
+	/**
+	 * @ORM\OneToMany(targetEntity="PHPStan\Rules\Doctrine\ORM\AnotherEntity", mappedBy="five")
+	 * @var \Doctrine\Common\Collections\Collection|\PHPStan\Rules\Doctrine\ORM\AnotherEntity[]
+	 */
+	private $oneToManyWithCorrectOldStyleAnnotation;
+
+}