take into account showgrid atrrs

archmoj · archmoj · commit 1b905a158875 · 2020-01-10T17:35:38.000-05:00
diff --git a/src/plots/geo/layout_defaults.js b/src/plots/geo/layout_defaults.js
@@ -61,6 +61,8 @@ function handleGeoDefaults(geoLayoutIn, geoLayoutOut, coerce, opts) {
         newTemplate.showocean = false;
         newTemplate.showrivers = false;
         newTemplate.showsubunits = false;
+        if(newTemplate.lonaxis) newTemplate.lonaxis.showgrid = false;
+        if(newTemplate.lataxis) newTemplate.lataxis.showgrid = false;
 
         // set ref to copy
         geoLayoutOut._template = newTemplate;
diff --git a/test/jasmine/tests/geo_test.js b/test/jasmine/tests/geo_test.js
@@ -662,7 +662,9 @@ describe('Test Geo layout defaults', function() {
                             showlakes: true,
                             showocean: true,
                             showrivers: true,
-                            showsubunits: true
+                            showsubunits: true,
+                            lonaxis: { showgrid: true },
+                            lataxis: { showgrid: true }
                         }
                     }
                 },

Original file line number	Diff line number	Diff line change
`@@ -662,7 +662,9 @@ describe('Test Geo layout defaults', function() {`
`662`	`662`	`showlakes: true,`
`663`	`663`	`showocean: true,`
`664`	`664`	`showrivers: true,`
`665`		`- showsubunits: true`
	`665`	`+ showsubunits: true,`
	`666`	`+ lonaxis: { showgrid: true },`
	`667`	`+ lataxis: { showgrid: true }`
`666`	`668`	`}`
`667`	`669`	`}`
`668`	`670`	`},`