Skip to content

Commit 986e8b0

Browse files
committed
make modebar button assest abstraction more robust
1 parent bc90474 commit 986e8b0

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

test/jasmine/assets/modebar_button.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,19 @@ var modeBarButtons = require('@src/components/modebar/buttons');
66

77

88
module.exports = function selectButton(modeBar, name) {
9-
var button = d3.select(modeBar.element)
9+
var button = {};
10+
11+
var node = button.node = d3.select(modeBar.element)
1012
.select('[data-title="' + modeBarButtons[name].title + '"]')
1113
.node();
1214

1315
button.click = function() {
1416
var ev = new window.MouseEvent('click');
15-
button.dispatchEvent(ev);
17+
node.dispatchEvent(ev);
1618
};
1719

1820
button.isActive = function() {
19-
return d3.select(button).classed('active');
21+
return d3.select(node).classed('active');
2022
};
2123

2224
return button;

0 commit comments

Comments
 (0)