Refactors set_dependencies

Doing both `go get` and checkout in the same loop made gpm prone
to race conditions - happening when we tried to set versions for
packages at the same time they were being installed.

Having this happening in two different loops makes the approach
more tidy and less prone to error.

Author: PoTe

bin/gpm

@@ -49,20 +49,22 @@ set_dependencies() {
       local install_path="${GOPATH%%:*}/src/${pkg_path%%/...}"
       echo ">> Getting package "$package""
 
-      # Retries in case of possible race conditions when installing a package
-      # dependency
-      for ((i=0; i<5; i++)); do
-        out=$(go get -u -d "$package" 2>&1 >/dev/null) && break
-      done
-      [[ $? != 0 ]] && echo "-- Failed to get "$package", error: " && echo "$out" && exit 1
+      go get -u -d "$package"
+    ) &
+  done < <(echo "$deps")
+  wait
 
+  while read package version; do
+    (
+      local pkg_path=$(echo "$package" | awk -F/ '{print $1"/"$2"/"$3}')
+      local install_path="${GOPATH%%:*}/src/${pkg_path%%/...}"
       echo ">> Setting $package to version $version"
       cd $install_path
       is_in_use $install_path && wait
 
-      [ -d .hg  ] && hg update    -q      "$version"
-      [ -d .git ] && git checkout -q      "$version"
       [ -d .bzr ] && bzr revert   -q -r   "$version"
+      [ -d .git ] && git checkout -q      "$version"
+      [ -d .hg  ] && hg update    -q      "$version"
       [ -d .svn ] && svn update   -r      "$version"
     ) &
   done < <(echo "$deps")

test/installs_correct_versions_test.sh

@@ -13,8 +13,10 @@ assert "go run go_code.go" "v6.2"
 version="a6a0a737c00caf4d4c2bb589941ace0d688168bb"
 echo "github.com/garyburd/redigo/redis $version" > Godeps
 assert_raises "$GPM"
-rm Godeps
-cd $GOPATH/src/github.com/garyburd/redigo
+cd "${GOPATH%%:*}/src/github.com/garyburd/redigo"
 assert "git rev-parse HEAD" "$version"
 
+## Cleanup
+rm Godeps
+
 assert_end examples