test: Add E2E tests for geo functions

jkhaliqi · jkhaliqi · commit f5029f7a83b8 · 2026-02-18T12:02:10.000-08:00
diff --git a/presto-native-execution/src/test/java/com/facebook/presto/nativeworker/NativeQueryRunnerUtils.java b/presto-native-execution/src/test/java/com/facebook/presto/nativeworker/NativeQueryRunnerUtils.java
@@ -487,4 +487,48 @@ public static void createBucketedLineitemAndOrders(QueryRunner queryRunner)
             queryRunner.execute("INSERT INTO orders_bucketed SELECT orderkey, custkey, orderstatus, '2021-12-21' FROM tpch.tiny.orders");
         }
     }
+
+    public static void createCoordinates(QueryRunner queryRunner)
+    {
+        queryRunner.execute("DROP TABLE IF EXISTS coordinates");
+        queryRunner.execute("CREATE TABLE coordinates (lat1 double, lon1 double, lat2 double, lon2 double, zoom integer, isvalid boolean)");
+        queryRunner.execute("INSERT INTO coordinates VALUES " +
+                "(0.0, 0.0, NULL, NULL, 0, true), " +
+                "(30.12, 60, NULL, NULL, 1, true), " +
+                "(30.12, 60, NULL, NULL, 15, true), " +
+                "(30.12, 60, NULL, NULL, 23, true), " +
+                "(-85.05112878, -180, NULL, NULL, 1, true), " +
+                "(-85.05112878, -180, NULL, NULL, 3, true), " +
+                "(-85.05112878, -180, NULL, NULL, 15, true), " +
+                "(0.0, 180.0, NULL, NULL, 2, true), " +
+                "(0.0, -180.0, NULL, NULL, 2, true), " +
+                "(85.0, 0.0, NULL, NULL, 3, true), " +
+                "(-85.0, 0.0, NULL, NULL, 3, true), " +
+                "(85.0, 180.0, NULL, NULL, 0, true), " +
+                "(-85.0, -180.0, NULL, NULL, 0, true), " +
+                "(45.0, 90.0, NULL, NULL, 10, true), " +
+                "(-45.0, -90.0, NULL, NULL, 10, true), " +
+                "(40.7128, -74.0060, NULL, NULL, 15, true), " +
+                "(51.5074, -0.1278, NULL, NULL, 20, true), " +
+                "(90.0, 0.0, NULL, NULL, 1, false), " +
+                "(0.0, 200.0, NULL, NULL, 1, false), " +
+                "(0.0, 0.0, NULL, NULL, 24, false), " +
+                "(0.0, 0.0, NULL, NULL, -1, false), " +
+                "(0.0, 0.0, NULL, NULL, 2, true), " +
+                "(40.7128, -74.0060, NULL, NULL, 5, true), " +
+                "(90.0, 0.0, NULL, NULL, 2, false), " +
+                "(0.0, -200.0, NULL, NULL, 2, false), " +
+                "(0.0, 0.0, NULL, NULL, -1, false), " +
+                "(90.0, 0.0, -90.0, 0.0, NULL, true), " +
+                "(0.0, 179.0, 0.0, -179.0, NULL, true), " +
+                "(37.7749, -122.4194, 37.7750, -122.4195, NULL, true), " +
+                "(0.0, 0.0, 0.0, 180.0, NULL, true), " +
+                "(40.7128, -74.0060, 51.5074, -0.1278, NULL, true), " +
+                "(-33.8688, 151.2093, 35.6762, 139.6503, NULL, true), " +
+                "(37.7749, -122.4194, 34.0522, -118.2437, NULL, true), " +
+                "(10.0, 0.0, -10.0, 0.0, NULL, true), " +
+                "(45.0, -5.0, 45.0, 5.0, NULL, true), " +
+                "(100.0, 0.0, 0.0, 0.0, NULL, false), " +
+                "(0.0, 200.0, 0.0, 0.0, NULL, false)");
+    }
 }
diff --git a/presto-native-tests/src/test/java/com/facebook/presto/nativetests/TestPrestoNativeGeospatial.java b/presto-native-tests/src/test/java/com/facebook/presto/nativetests/TestPrestoNativeGeospatial.java
@@ -18,12 +18,25 @@
 import com.facebook.presto.testing.ExpectedQueryRunner;
 import com.facebook.presto.testing.QueryRunner;
 import com.facebook.presto.tests.AbstractTestQueryFramework;
+import com.google.common.collect.ImmutableList;
 import org.intellij.lang.annotations.Language;
 import org.testng.annotations.Test;
 
+import java.util.UUID;
+
+import static com.facebook.presto.common.type.BigintType.BIGINT;
+import static com.facebook.presto.nativeworker.NativeQueryRunnerUtils.createCoordinates;
+import static java.lang.String.format;
+
 public class TestPrestoNativeGeospatial
         extends AbstractTestQueryFramework
 {
+    @Override
+    protected void createTables()
+    {
+        QueryRunner queryRunner = (QueryRunner) getExpectedQueryRunner();
+        createCoordinates(queryRunner);
+    }
     @Override
     protected QueryRunner createQueryRunner()
             throws Exception
@@ -58,4 +71,73 @@ public void setSessionNativeUseVeloxGeospatialJoin()
                 .build();
         assertQuery(actualSession, query);
     }
+
+    @Test
+    public void testBingTileAt()
+    {
+        assertQuery("SELECT bing_tile_at(lat1, lon1, zoom) FROM coordinates WHERE isvalid = true");
+        assertQueryFails("SELECT bing_tile_at(lat1, lon1, zoom) FROM coordinates WHERE lat1 = 90.0 AND zoom = 1",
+                "(?s).*Latitude.*outside of valid range.*-85.05112878.*85.05112878.*");
+        assertQueryFails("SELECT bing_tile_at(lat1, lon1, zoom) FROM coordinates WHERE lon1 = 200.0 AND zoom = 1",
+                "(?s).*Longitude.*outside of valid range.*-180.*180.*");
+        assertQueryFails("SELECT bing_tile_at(lat1, lon1, zoom) FROM coordinates WHERE zoom = 24",
+                "(?s).*zoom.*23.*");
+        assertQueryFails("SELECT bing_tile_at(lat1, lon1, zoom) FROM coordinates WHERE zoom = -1",
+                "(?s).*zoom.*negative.*");
+    }
+
+    @Test
+    public void testBingTilePolygon()
+    {
+        String tmpTableName = generateRandomTableName();
+        getQueryRunner().execute(format("CREATE TABLE %s " +
+                "(x integer, y integer, z integer, isvalid boolean)", tmpTableName));
+        getQueryRunner().execute(format("INSERT INTO %s VALUES " +
+                "(0, 0, 1, true)," +
+                "(3, 3, 3, true)," +
+                "(7, 7, 4, true)," +
+                "(0, 0, 5, true)," +
+                "(31, 31, 5, true)," +
+                "(100, 100, 10, true)," +
+                "(2, 0, 1, false) ", tmpTableName));
+        assertQuery(format("SELECT bing_tile_polygon(BING_TILE(x, y, z)) FROM %s WHERE isvalid = true", tmpTableName));
+        assertQueryFails(format("SELECT bing_tile_polygon(BING_TILE(x, y, z)) FROM %s WHERE isvalid = false", tmpTableName),
+                "(?s).*X coordinate.*greater than max coordinate.*zoom.*");
+    }
+
+    @Test
+    public void testBingTilesAround()
+    {
+        assertQuery("SELECT cardinality(bing_tiles_around(lat1, lon1, zoom)) FROM coordinates WHERE isvalid = true");
+        assertQueryFails("SELECT bing_tiles_around(lat1, lon1, zoom) FROM coordinates WHERE lat1 = 90.0 AND zoom = 2",
+                "(?s).*Latitude.*outside of valid range.*-85.05112878.*85.05112878.*");
+        assertQueryFails("SELECT bing_tiles_around(lat1, lon1, zoom) FROM coordinates WHERE lon1 = -200.0 AND zoom = 2",
+                "(?s).*Longitude.*outside of valid range.*-180.*180.*");
+        assertQueryFails("SELECT bing_tiles_around(lat1, lon1, zoom) FROM coordinates WHERE zoom = -1",
+                "(?s).*zoom.*negative.*");
+    }
+
+    @Test
+    public void testGreatCircleDistance()
+    {
+        assertQuery("SELECT great_circle_distance(lat1, lon1, lat2, lon2) FROM coordinates WHERE lat2 IS NOT NULL AND isvalid = true");
+        assertQueryFails("SELECT great_circle_distance(lat1, lon1, lat2, lon2) FROM coordinates WHERE lat1 = 100.0",
+                "(?s).*Latitude.*range.*-90.*90.*");
+        assertQueryFails("SELECT great_circle_distance(lat1, lon1, lat2, lon2) FROM coordinates WHERE lon1 = 200.0",
+                "(?s).*longitude.*range.*-180.*180.*");
+    }
+
+    private String generateRandomTableName()
+    {
+        String tableName = "tmp_presto_" + UUID.randomUUID().toString().replace("-", "");
+        // Clean up if the temporary named table already exists.
+        dropTableIfExists(tableName);
+        return tableName;
+    }
+
+    private void dropTableIfExists(String tableName)
+    {
+        // An ugly workaround for the lack of getExpectedQueryRunner()
+        computeExpected(format("DROP TABLE IF EXISTS %s", tableName), ImmutableList.of(BIGINT));
+    }
 }
diff --git a/presto-tests/src/main/java/com/facebook/presto/tests/TestingPrestoClient.java b/presto-tests/src/main/java/com/facebook/presto/tests/TestingPrestoClient.java
@@ -81,6 +81,7 @@
 import static com.facebook.presto.common.type.TimestampWithTimeZoneType.TIMESTAMP_WITH_TIME_ZONE;
 import static com.facebook.presto.common.type.TinyintType.TINYINT;
 import static com.facebook.presto.common.type.VarbinaryType.VARBINARY;
+import static com.facebook.presto.geospatial.type.BingTileType.BING_TILE;
 import static com.facebook.presto.testing.MaterializedResult.DEFAULT_PRECISION;
 import static com.facebook.presto.type.IntervalDayTimeType.INTERVAL_DAY_TIME;
 import static com.facebook.presto.type.IntervalYearMonthType.INTERVAL_YEAR_MONTH;
@@ -250,6 +251,9 @@ else if (IPADDRESS.equals(type)) {
         else if (IPPREFIX.equals(type)) {
             return value;
         }
+        else if (BING_TILE.equals(type)) {
+            return value;
+        }
         else if (type instanceof ArrayType) {
             return ((List<Object>) value).stream()
                     .map(element -> convertToRowValue(((ArrayType) type).getElementType(), element))
