Skip to content

Refactor fetch-examples script to only use async/await #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
catarak opened this issue Nov 24, 2020 · 2 comments · Fixed by #1694
Closed

Refactor fetch-examples script to only use async/await #1693

catarak opened this issue Nov 24, 2020 · 2 comments · Fixed by #1694
Labels
Good First Issue A beginner-friendly issue, great for first-time contributors Help Wanted Would love additional input or contributions! Priority:High Should be addressed soon but not critical Type:Task Tasks tied specifically to developer operations and maintenance

Comments

@catarak
Copy link
Member

catarak commented Nov 24, 2020

Nature of issue?

  • Existing feature enhancement

Feature enhancement details:

The file examples.js has been edited by many people over the years and could use a refactor. It uses callbacks, Promises, and async/await, and I think that it should be refactored to just use async/await.
@catarak catarak added Help Wanted Would love additional input or contributions! Priority:High Should be addressed soon but not critical Type:Task Tasks tied specifically to developer operations and maintenance Good First Issue A beginner-friendly issue, great for first-time contributors labels Nov 24, 2020
@Swapnil-2001
Copy link
Contributor

Hi @catarak can I take up this issue please?

@catarak
Copy link
Member Author

catarak commented Nov 24, 2020

@Swapnil-2001 absolutely!

@Swapnil-2001 Swapnil-2001 mentioned this issue Nov 25, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue A beginner-friendly issue, great for first-time contributors Help Wanted Would love additional input or contributions! Priority:High Should be addressed soon but not critical Type:Task Tasks tied specifically to developer operations and maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor examples.js to use async/await
2 participants
@catarak @Swapnil-2001