Skip to content

[Developer Experience] Use Github Actions to providing linting feedback on PRs #1720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hydrosquall opened this issue Dec 24, 2020 · 3 comments

Comments

@hydrosquall
Copy link

hydrosquall commented Dec 24, 2020

Nature of issue?

New feature details:

@hydrosquall
Copy link
Author

Ah I see that https://travis-ci.com/github/processing/p5.js-web-editor/jobs/456150755 exists, perhaps the issue was more about what mismatches constitute "warnings" vs "errors".

With that said, it may be worthwhile to migrate anyways given that the future of open source plans in Travis seems uncertain- I migrated the CI for my own project a few weeks ago for this reason.

hydrosquall/tiingo-python#546

@catarak
Copy link
Member

catarak commented Jan 4, 2021

Thanks for opening this issue! husky linting hooks got added to this project so that linting errors aren't getting committed to this project anymore. I'm also in the process of adding prettier which will also help with linting issues.

I didn't know that Travis had changed their open source pricing—I'm going to reach out to them right now to see if we can get some credits!

@catarak
Copy link
Member

catarak commented Jan 27, 2021

Fixed via #1735.

@catarak catarak closed this as completed Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants