-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add logging with winston #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
totally! it would be amazing to add a logging library. maybe this ticket could be that—investigate and add logging library? |
Yeah , I will look into it and start refactoring |
As I was looking through the code , I found out that most of the console statements were used for debugging and some for handling errors.
|
sounds great to me! |
@catarak I was thinking of a solution to this ticket. |
|
@siddhant1 Could I please work on this issue while you're working on the other ones? Thank you! |
Hey Gaurang , this issue was already solved and needs to be closed. You can work on other ones :) |
@siddhant1 / @GaurangTandon this issue hasn't been solved. no logging library has been added. |
The issue was originally to remove logs which was done , for adding logging library , I will send a pr soon |
I think we should remove console.logs from the code
Links :- https://dev.to/mornir/-dont-leave-console-logs-in-production-14na
https://hackernoon.com/please-stop-using-console-log-its-broken-b5d7d396cf15
I can send in a PR
Have a look @catarak
The text was updated successfully, but these errors were encountered: