Skip to content

FES: internationalization for validateParameters #4616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
akshay-99 opened this issue Jun 7, 2020 · 0 comments · Fixed by #4629
Closed
1 task done

FES: internationalization for validateParameters #4616

akshay-99 opened this issue Jun 7, 2020 · 0 comments · Fixed by #4629

Comments

@akshay-99
Copy link
Member

Most appropriate sub-area of p5.js?

  • Other (Friendly errors, internationalization)

Feature enhancement details:

#4233 adds internationalization support for FES functionality with the exception of validateParameters. Perhaps I could add that in?

Also since the entire internationalization tooling is not used in the minified version, perhaps we can import it conditionally by checking for window.IS_MINIFIED and exclude it in the browserify config for the minified build. This would also remove all of i18next and i18next-browser-languagedetector from the minified script, cutting down the final size quite a bit.

Also, this line tries to exclude translations from the minified build, but if we search for something like "Su browser impidío un medio tocar" in the minified file, we can see that the translations are still included

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant