Skip to content

Visual Testing Documentation Mismatch #7807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 17 tasks
pnngocdoan opened this issue May 13, 2025 · 0 comments · May be fixed by #7827
Open
1 of 17 tasks

Visual Testing Documentation Mismatch #7807

pnngocdoan opened this issue May 13, 2025 · 0 comments · May be fixed by #7827

Comments

@pnngocdoan
Copy link

Most appropriate sub-area of p5.js?

  • Accessibility
  • Color
  • Core/Environment/Rendering
  • Data
  • DOM
  • Events
  • Image
  • IO
  • Math
  • Typography
  • Utilities
  • WebGL
  • Build process
  • Unit testing
  • Internationalization
  • Friendly errors
  • Other (specify if possible)

p5.js version

No response

Web browser and version

No response

Operating system

No response

Steps to reproduce this

There's a mismatch in documentation for visual testing. The current visual tests at main branch only have a simple pixel-to-pixel comparison. I checked dev-2.0 and found the advanced algorithms that are introduced here. However, there was no Gruntfile at the dev-2.0 and it used vitest instead, while the documentation suggested using grunt. The vitest was also headless so I can't manually inspect the visual tests (I used npx vitest to open the tests in a browser but couldn't manually inspect each visual test either)

@pnngocdoan pnngocdoan added the Bug label May 13, 2025
@perminder-17 perminder-17 added this to the 2.x Anytime milestone May 15, 2025
@perminder-17 perminder-17 moved this to Ready for Work in p5.js 2.x 🌱🌳 May 15, 2025
@perminder-17 perminder-17 linked a pull request Jun 3, 2025 that will close this issue
@ksen0 ksen0 modified the milestones: 2.x Anytime, 2.1 Jun 7, 2025
@ksen0 ksen0 moved this from Ready for Work to In Progress in p5.js 2.x 🌱🌳 Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants