Merge pull request #7294 from mikhail5555/fix/data-race-condition-global-variable

Fix(clientpool): remove global variable from clientpool in favour for local variable

Author: Mzack9999

pkg/protocols/common/protocolinit/init.go

@@ -4,7 +4,6 @@ import (
 	"github.com/projectdiscovery/nuclei/v3/pkg/js/compiler"
 	"github.com/projectdiscovery/nuclei/v3/pkg/protocols/common/protocolstate"
 	"github.com/projectdiscovery/nuclei/v3/pkg/protocols/dns/dnsclientpool"
-	"github.com/projectdiscovery/nuclei/v3/pkg/protocols/http/httpclientpool"
 	"github.com/projectdiscovery/nuclei/v3/pkg/protocols/http/signerpool"
 	"github.com/projectdiscovery/nuclei/v3/pkg/protocols/network/networkclientpool"
 	"github.com/projectdiscovery/nuclei/v3/pkg/protocols/whois/rdapclientpool"
@@ -20,9 +19,6 @@ func Init(options *types.Options) error {
 	if err := dnsclientpool.Init(options); err != nil {
 		return err
 	}
-	if err := httpclientpool.Init(options); err != nil {
-		return err
-	}
 	if err := signerpool.Init(options); err != nil {
 		return err
 	}

pkg/protocols/http/httpclientpool/clientpool.go

@@ -28,19 +28,6 @@ import (
 	urlutil "github.com/projectdiscovery/utils/url"
 )
 
-var (
-	forceMaxRedirects int
-)
-
-// Init initializes the clientpool implementation
-func Init(options *types.Options) error {
-	if options.ShouldFollowHTTPRedirects() {
-		forceMaxRedirects = options.MaxRedirects
-	}
-
-	return nil
-}
-
 // ConnectionConfiguration contains the custom configuration options for a connection
 type ConnectionConfiguration struct {
 	// DisableKeepAlive of the connection
@@ -221,15 +208,17 @@ func wrappedGet(options *types.Options, configuration *Configuration) (*retryabl
 	redirectFlow := configuration.RedirectFlow
 	maxRedirects := configuration.MaxRedirects
 
-	if forceMaxRedirects > 0 {
+	if options.ShouldFollowHTTPRedirects() {
 		// by default we enable general redirects following
 		switch {
 		case options.FollowHostRedirects:
 			redirectFlow = FollowSameHostRedirect
 		default:
 			redirectFlow = FollowAllRedirect
 		}
-		maxRedirects = forceMaxRedirects
+		if options.MaxRedirects > 0 {
+			maxRedirects = options.MaxRedirects
+		}
 	}
 	if options.DisableRedirects {
 		options.FollowRedirects = false