From 3dce00f854aa1002fd41005c363202724db4273e Mon Sep 17 00:00:00 2001 From: Christian Albrecht Date: Tue, 5 Sep 2023 12:36:49 +0200 Subject: [PATCH] Fix a connection leak The leak was introduced in PR#882 Signed-off-by: Christian Albrecht --- collector/collector.go | 1 + collector/probe.go | 1 + 2 files changed, 2 insertions(+) diff --git a/collector/collector.go b/collector/collector.go index e06ef7d1c..c643bd91e 100644 --- a/collector/collector.go +++ b/collector/collector.go @@ -173,6 +173,7 @@ func (p PostgresCollector) Collect(ch chan<- prometheus.Metric) { level.Error(p.logger).Log("msg", "Error opening connection to database", "err", err) return } + defer p.instance.Close() wg := sync.WaitGroup{} wg.Add(len(p.Collectors)) diff --git a/collector/probe.go b/collector/probe.go index a7630272e..4c0f0419b 100644 --- a/collector/probe.go +++ b/collector/probe.go @@ -81,6 +81,7 @@ func (pc *ProbeCollector) Collect(ch chan<- prometheus.Metric) { level.Error(pc.logger).Log("msg", "Error opening connection to database", "err", err) return } + defer pc.instance.Close() wg := sync.WaitGroup{} wg.Add(len(pc.collectors))