Skip to content

License metadata issues #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kyle-Neale opened this issue May 28, 2025 · 1 comment
Closed

License metadata issues #1110

Kyle-Neale opened this issue May 28, 2025 · 1 comment

Comments

@Kyle-Neale
Copy link

Description

We have license validations we perform on dependencies we're shipping and prometheus-client has changed. The license metadata looks bungled going from 0.21.1 to 0.22.0.

@csmarchbanks
Copy link
Member

Hello, yes the packaging did change a bit following the move from setup.py to pyproject.toml. Currently it is following PEP 621, which allows specifying the entire license file: https://peps.python.org/pep-0621/#license. However, that was recently deprecated and we should probably move to license expressions instead. Either way, that will be a bit of a change from 0.21.x and earlier as the best practices for including licenses has changed.

I have created #1111 to move to the most recent guidance, I don't know what your parsing looks for today but it would need to parse the license_expression json field moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants