Skip to content

Commit b6738e0

Browse files
authored
Stop using pyasn1.compat.octets
1 parent 36b0363 commit b6738e0

File tree

7 files changed

+8
-15
lines changed

7 files changed

+8
-15
lines changed

tests/test_pem.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import sys
88
import unittest
99

10-
from pyasn1.compat.octets import ints2octs
1110
from pyasn1_modules import pem
1211

1312

@@ -93,7 +92,7 @@ def testReadBase64fromText(self):
9392
24, 102, 241, 236, 50
9493
]
9594

96-
self.assertEqual(ints2octs(expected), binary)
95+
self.assertEqual(bytes(expected), binary)
9796

9897

9998
suite = unittest.TestLoader().loadTestsFromModule(sys.modules[__name__])

tests/test_rfc3770.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
from pyasn1.codec.der.decoder import decode as der_decoder
1212
from pyasn1.codec.der.encoder import encode as der_encoder
13-
from pyasn1.compat.octets import str2octs
1413

1514
from pyasn1_modules import pem
1615
from pyasn1_modules import rfc5480
@@ -79,7 +78,7 @@ def testOpenTypes(self):
7978
self.assertEqual(extn['extnValue'], der_encoder(extnValue))
8079

8180
if extn['extnID'] == rfc3770.id_pe_wlanSSID:
82-
self.assertIn(str2octs('Example'), extnValue)
81+
self.assertIn(b'Example', extnValue)
8382

8483
if extn['extnID'] == rfc5280.id_ce_extKeyUsage:
8584
self.assertIn(rfc3770.id_kp_eapOverLAN, extnValue)

tests/test_rfc4073.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
from pyasn1.codec.der.decoder import decode as der_decoder
1212
from pyasn1.codec.der.encoder import encode as der_encoder
13-
from pyasn1.compat.octets import str2octs
1413

1514
from pyasn1_modules import pem
1615
from pyasn1_modules import rfc2634
@@ -131,7 +130,7 @@ def testOpenTypes(self):
131130

132131
self.assertIn(next_ci['contentType'], rfc5652.cmsContentTypesMap)
133132
self.assertEqual(rfc5652.id_data, next_ci['contentType'])
134-
self.assertIn(str2octs('Content-Type: text'), next_ci['content'])
133+
self.assertIn(b'Content-Type: text', next_ci['content'])
135134

136135
for attr in ci['content']['attrs']:
137136
self.assertIn(attr['attrType'], rfc5652.cmsAttributesMap)

tests/test_rfc4334.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
from pyasn1.codec.der.decoder import decode as der_decoder
1212
from pyasn1.codec.der.encoder import encode as der_encoder
13-
from pyasn1.compat.octets import str2octs
1413

1514
from pyasn1_modules import pem
1615
from pyasn1_modules import rfc5280
@@ -67,7 +66,7 @@ def testOpenTypes(self):
6766
self.assertEqual(extn['extnValue'], der_encoder(extnValue))
6867

6968
if extn['extnID'] == rfc4334.id_pe_wlanSSID:
70-
self.assertIn( str2octs('Example'), extnValue)
69+
self.assertIn(b'Example', extnValue)
7170

7271
if extn['extnID'] == rfc5280.id_ce_extKeyUsage:
7372
self.assertIn(rfc4334.id_kp_eapOverLAN, extnValue)

tests/test_rfc5755.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
from pyasn1.codec.der.decoder import decode as der_decoder
1212
from pyasn1.codec.der.encoder import encode as der_encoder
13-
from pyasn1.compat.octets import str2octs
1413

1514
from pyasn1_modules import pem
1615
from pyasn1_modules import rfc5280
@@ -85,7 +84,7 @@ def testOpenTypes(self):
8584
count += 1
8685
if attr['type'] == rfc5755.id_aca_authenticationInfo:
8786
self.assertEqual(
88-
str2octs('password'), attr['values'][0]['authInfo'])
87+
b'password', attr['values'][0]['authInfo'])
8988

9089
self.assertEqual(5, count)
9190

tests/test_rfc6032.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
from pyasn1.codec.der.decoder import decode as der_decoder
1212
from pyasn1.codec.der.encoder import encode as der_encoder
13-
from pyasn1.compat.octets import str2octs
1413

1514
from pyasn1_modules import pem
1615
from pyasn1_modules import rfc5652
@@ -64,7 +63,7 @@ def testDerCodec(self):
6463
self.assertFalse(rest)
6564
self.assertTrue(keyid.prettyPrint())
6665
self.assertEqual(attrVal0, der_encoder(keyid))
67-
self.assertEqual(str2octs('ptf-kdc-812374'), keyid)
66+
self.assertEqual(b'ptf-kdc-812374', keyid)
6867

6968
def testOpenTypes(self):
7069
substrate = pem.readBase64fromText(self.encrypted_key_pkg_pem_text)
@@ -86,8 +85,8 @@ def testOpenTypes(self):
8685
self.assertNotEqual('0x', attr['attrValues'][0].prettyPrint()[:2])
8786

8887
if attr['attrType'] == rfc6032.id_aa_KP_contentDecryptKeyID:
89-
self.assertEqual(str2octs(
90-
'ptf-kdc-812374'), attr['attrValues'][0])
88+
self.assertEqual(
89+
b'ptf-kdc-812374', attr['attrValues'][0])
9190

9291

9392
suite = unittest.TestLoader().loadTestsFromModule(sys.modules[__name__])

tests/test_rfc6120.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
from pyasn1.codec.der.decoder import decode as der_decoder
1212
from pyasn1.codec.der.encoder import encode as der_encoder
13-
from pyasn1.compat.octets import str2octs
1413

1514
from pyasn1_modules import pem
1615
from pyasn1_modules import rfc5280

0 commit comments

Comments
 (0)