Skip to content

Add support for multiple themes #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 9, 2020

Conversation

JonasUJ
Copy link
Contributor

@JonasUJ JonasUJ commented Aug 18, 2020

This closes #46

It basically generates a unique bulma.css stylesheet for each theme. I also decided that we should log a warning if someone tries to use a theme they haven't defined.

@ghost ghost added the needs 2 approvals label Aug 18, 2020
@JonasUJ
Copy link
Contributor Author

JonasUJ commented Aug 18, 2020

The checks are failing on code I didn't introduce

@lemonsaurus
Copy link
Owner

The checks are failing on code I didn't introduce

Looks like it's just the trailing whitespace checker. Why don't you set up the pre-commit and just run it? It'll fix it right up.

@lemonsaurus
Copy link
Owner

To be perfectly clear, even though this PR didn't introduce this code, it's fine if you make a kaizen commit that fixes some trailing whitespace.

Copy link
Owner

@lemonsaurus lemonsaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable. Your code is, as usual, quite good. Nice work.

I should probably test it before merging.

Copy link
Owner

@lemonsaurus lemonsaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work. I'll merge and release it.

@lemonsaurus lemonsaurus merged commit ccd4ede into lemonsaurus:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alternative variables dict in BULMA_SETTINGS
2 participants