drop support for Python 3.8 (#9692)

Co-authored-by: Randy Döring <[email protected]>
Co-authored-by: Sven van Ashbrook <[email protected]>

Author: 3 people

.cirrus.yml

@@ -8,10 +8,6 @@ tests_task:
 
   env:
     matrix:
-      - PYTHON: python3.8
-        PYTHON_VERSION: 3.8
-        PYTHON_PACKAGE: python38
-        SQLITE_PACKAGE: py38-sqlite3
       - PYTHON: python3.9
         PYTHON_VERSION: 3.9
         PYTHON_PACKAGE: python39

.github/workflows/.tests-matrix.yaml

@@ -101,7 +101,11 @@ jobs:
 
       - name: Use local poetry
         working-directory: poetry-plugin-export
-        run: poetry add --lock --group dev ../poetry
+        # Replace the python version to avoid conflicts
+        # if the plugin still supports a wider range than Poetry itself.
+        run: |
+          perl -pi -e 's/^python =.*$/python = "~${{ inputs.python-version }}"/' pyproject.toml
+          poetry add --lock --group dev ../poetry
 
       # This step can be removed after having released a poetry-plugin-export version
       # that has cffi>=1.17.0 in its lock file.

.github/workflows/tests.yaml

@@ -124,7 +124,6 @@ jobs:
           - name: macOS aarch64
             image: macos-14
         python-version:
-          - "3.8"
           - "3.9"
           - "3.10"
           - "3.11"

poetry.lock

@@ -29,7 +29,7 @@ Changelog = "https://python-poetry.org/history/"
 
 # Requirements
 [tool.poetry.dependencies]
-python = "^3.8"
+python = "^3.9"
 
 poetry-core = { git = "https://github.com/python-poetry/poetry-core.git", branch = "main" }
 build = "^1.2.1"
@@ -104,7 +104,7 @@ extend-exclude = [
 ]
 fix = true
 line-length = 88
-target-version = "py38"
+target-version = "py39"
 
 [tool.ruff.lint]
 extend-select = [

pyproject.toml

@@ -7,7 +7,6 @@
 from cleo.helpers import option
 
 from poetry.console.commands.command import Command
-from poetry.utils._compat import is_relative_to
 
 
 if TYPE_CHECKING:
@@ -55,8 +54,8 @@ def handle(self) -> int:
             self.line(f"Deleted virtualenv: <comment>{venv.path}</comment>")
         if remove_all_envs or is_in_project:
             for venv in manager.list():
-                if not is_in_project or is_relative_to(
-                    venv.path, self.poetry.pyproject_path.parent
+                if not is_in_project or venv.path.is_relative_to(
+                    self.poetry.pyproject_path.parent
                 ):
                     manager.remove_venv(venv.path)
                     self.line(f"Deleted virtualenv: <comment>{venv.path}</comment>")

src/poetry/console/commands/env/remove.py

@@ -1,12 +1,11 @@
 from __future__ import annotations
 
+from collections.abc import Mapping
 from contextlib import suppress
 from pathlib import Path
 from typing import TYPE_CHECKING
 from typing import Any
 from typing import ClassVar
-from typing import Dict
-from typing import Mapping
 from typing import Union
 
 from cleo.helpers import option
@@ -27,7 +26,7 @@
 
     from poetry.repositories import RepositoryPool
 
-Requirements = Dict[str, Union[str, Mapping[str, Any]]]
+Requirements = dict[str, Union[str, Mapping[str, Any]]]
 
 
 class InitCommand(Command):

src/poetry/console/commands/init.py

@@ -9,8 +9,6 @@
 from pathlib import Path
 from typing import TYPE_CHECKING
 from typing import Any
-from typing import Mapping
-from typing import Sequence
 
 import pkginfo
 
@@ -31,6 +29,8 @@
 
 if TYPE_CHECKING:
     from collections.abc import Iterator
+    from collections.abc import Mapping
+    from collections.abc import Sequence
 
     from packaging.metadata import RawMetadata
     from packaging.utils import NormalizedName
@@ -523,7 +523,7 @@ def from_path(cls, path: Path) -> PackageInfo:
             return cls.from_sdist(path=path)
 
 
-@functools.lru_cache(maxsize=None)
+@functools.cache
 def get_pep517_metadata(path: Path) -> PackageInfo:
     """
     Helper method to use PEP-517 library to build and read package metadata.

src/poetry/inspection/info.py

@@ -209,10 +209,7 @@ def _serialize(
                 self._shutdown = True
 
             if self._shutdown:
-                # Cancelling further tasks from being executed
-                [task.cancel() for task in tasks]
-                self._executor.shutdown(wait=True)
-
+                self._executor.shutdown(wait=True, cancel_futures=True)
                 break
 
         for warning in self._yanked_warnings:

src/poetry/installation/executor.py

@@ -6,7 +6,6 @@
 
 from typing import TYPE_CHECKING
 from typing import Optional
-from typing import Tuple
 
 from poetry.core.packages.dependency import Dependency
 
@@ -32,7 +31,7 @@
 _conflict = object()
 
 
-DependencyCacheKey = Tuple[
+DependencyCacheKey = tuple[
     str, Optional[str], Optional[str], Optional[str], Optional[str]
 ]