Borrow asyncio ssl implementation from uvloop

[asvetlov]

BPO	44011
Nosy	@asvetlov, @1st1, @pablogsal, @kumaraditya303
PRs	bpo-44011: New asyncio ssl implementation #17975 bpo-44011: Fix asyncio tests without ssl module (GH-25840) #25840 bpo-44011: Increase test timeout #25842 bpo-44011: Increase timeouts for asyncio SSL tests #25846 bpo-44011: Revert "New asyncio ssl implementation (GH-17975)" #25848 bpo-44011: New asyncio ssl implementation #31275 bpo-44011: add docs for ssl_shutdown_timeout parameter #31597

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/asvetlov'
closed_at = <Date 2022-02-22.21:12:45.984>
created_at = <Date 2021-05-02.20:33:39.996>
labels = ['3.11', 'type-feature', 'expert-asyncio']
title = 'Borrow asyncio ssl implementation from uvloop'
updated_at = <Date 2022-02-26.13:06:50.530>
user = 'https://github.com/asvetlov'

bugs.python.org fields:

activity = <Date 2022-02-26.13:06:50.530>
actor = 'asvetlov'
assignee = 'asvetlov'
closed = True
closed_date = <Date 2022-02-22.21:12:45.984>
closer = 'asvetlov'
components = ['asyncio']
creation = <Date 2021-05-02.20:33:39.996>
creator = 'asvetlov'
dependencies = []
files = []
hgrepos = []
issue_num = 44011
keywords = ['patch']
message_count = 18.0
messages = ['392726', '392739', '392769', '392771', '392774', '392775', '392776', '392798', '392799', '392800', '392802', '392813', '392815', '413062', '413065', '413288', '413289', '414102']
nosy_count = 4.0
nosy_names = ['asvetlov', 'yselivanov', 'pablogsal', 'kumaraditya']
pr_nums = ['17975', '25840', '25842', '25846', '25848', '31275', '31597']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue44011'
versions = ['Python 3.11']

[pablogsal]

Since commit 5fb06ed was merged there are multiple timeouts in several buildbots. Unfortunately if this is not fixed by the time I need to do the beta release I may need to revert all these commits until all buildbots are stable again.

Could someone investigate those timeouts?

For instance, check:

https://buildbot.python.org/all/#/builders/464/builds/138

[tiran]

When was https://buildbot.python.org/all/#/builders/464/builds/138 start? The build properties tab doesn't have a start timestamp.

Andrew, increase timeout doesn't seem to help. It's looks like the test suite is leaking threads on error.

[pablogsal]

I have created #25848 for the revert, in case this is not fixed in the next hours or so.

Given the nature of PR 17975, this should have tested with the buildbots as the release team asked in:

https://mail.python.org/archives/list/python-committers@python.org/thread/SIJQE3BZ6ICCGNJWFR4YR65BQBJJZZAZ/

and

https://mail.python.org/archives/list/python-committers@python.org/thread/V7V5JHKZCJVE2GTI5NFEP3PNKOLH35VL/

[pablogsal]

Specifically this part of both messages:

> If your change involves some platform-specific behaviour or has a
> non-trivial amount of C code, make sure you run the buildbots
> in your Pull Request by using the "test-with-buildbots" label (
> https://discuss.python.org/t/now-you-can-test-a-pr-with-the-buildbots-before...).
> Alternatively you could check the buildbots post-merge in the buildbot server:
> https://buildbot.python.org/all/#/builders?tags=%2B3.x&tags=%2Bstable
> This is very important because if problems are detected at the time >> of the
> release, the release management team may have to revert
> the changes and therefore those will not be included in Python 3.10.

[pablogsal]

New changeset 7719953 by Pablo Galindo in branch 'master':
bpo-44011: Revert "New asyncio ssl implementation (GH-17975)" (GH-25848)
7719953

[pablogsal]

Unfortunately I have reverted 5fb06ed commit to unblock the beta release :(

I know that nobody wants this but my responsibilities as a release manager is to safeguard the stability of the release and we are too close to the beta release to do all the testing we need, giving that many buildbots have been broken in a short timespan.

Andrew, we can try to get your PR merge between beta 1 and beta 2 but once we have done extensive testing and we know that there will be no impact on the buildbots and the CI.

Thank you all for your understanding

[kumaraditya303]

Since it was reverted as it was beta period, Can this be committed again as 3.11 is in alpha currently? @asvetlov

[kumaraditya303]

I created a draft PR by rebasing the old implementation of 3.10 for 3.11 so we can investigate the build-bots failure and fix them so this can be committed for 3.11.

See #31275

[asvetlov]

New changeset 13c10bf by Kumar Aditya in branch 'main':
bpo-44011: New asyncio ssl implementation (bpo-31275)
13c10bf

[asvetlov]

The code had landed.
Need a follow-up PR with documentation update (mention new ssl_shutdown_timeout arguments)

[asvetlov]

New changeset 41ddcd3 by Kumar Aditya in branch 'main':
bpo-44011: Document ssl_shutdown_timeout added by revisited asyncio SSL implementation (GH-31597)
41ddcd3