From c885256356f7e9a8aad927b88776892c8a0f3759 Mon Sep 17 00:00:00 2001 From: Xiang Zhang Date: Thu, 16 Feb 2017 12:34:40 +0800 Subject: [PATCH 1/3] Fix possibly dereferencing undefined pointers when creating weakref objects --- Objects/weakrefobject.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Objects/weakrefobject.c b/Objects/weakrefobject.c index d12db9185d8611..da05950f3f4207 100644 --- a/Objects/weakrefobject.c +++ b/Objects/weakrefobject.c @@ -24,6 +24,8 @@ init_weakref(PyWeakReference *self, PyObject *ob, PyObject *callback) { self->hash = -1; self->wr_object = ob; + self->wr_prev = NULL; + self->wr_next = NULL; Py_XINCREF(callback); self->wr_callback = callback; } From 2abca93f64410616602e5494f746172e7b4ae399 Mon Sep 17 00:00:00 2001 From: Xiang Zhang Date: Thu, 16 Feb 2017 13:28:41 +0800 Subject: [PATCH 2/3] add entry in Misc/NEWS --- Misc/NEWS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Misc/NEWS b/Misc/NEWS index 1422627b9052a2..f2ae6abb71472d 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -10,6 +10,9 @@ What's New in Python 3.7.0 alpha 1? Core and Builtins ----------------- +- bpo-29347: Fixed possibly dereferencing underfined pointers + when creating weakref objects. + - bpo-29438: Fixed use-after-free problem in key sharing dict. - bpo-29546: Set the 'path' and 'name' attribute on ImportError for ``from ... import ...``. From fda38aa9bb9be2c8bcc0fd8231e35c289ed39bd1 Mon Sep 17 00:00:00 2001 From: Xiang Zhang Date: Thu, 16 Feb 2017 14:42:18 +0800 Subject: [PATCH 3/3] fix typo --- Misc/NEWS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Misc/NEWS b/Misc/NEWS index f2ae6abb71472d..cb086c46e447e3 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -10,7 +10,7 @@ What's New in Python 3.7.0 alpha 1? Core and Builtins ----------------- -- bpo-29347: Fixed possibly dereferencing underfined pointers +- bpo-29347: Fixed possibly dereferencing undefined pointers when creating weakref objects. - bpo-29438: Fixed use-after-free problem in key sharing dict.