Code Review fixes

Author: David Euresti

stdlib/2/os/__init__.pyi

@@ -97,16 +97,16 @@ TMP_MAX = 0  # Undocumented, but used by tempfile
 _PathType = Union[bytes, Text]
 
 class stat_result(NamedTuple('stat_result', [
-        ('st_mode', int),  # protection bits,
-        ('st_ino', int),  # inode number,
-        ('st_dev', int),  # device,
-        ('st_nlink', int),  # number of hard links,
-        ('st_uid', int),  # user id of owner,
-        ('st_gid', int),  # group id of owner,
-        ('st_size', int),  # size of file, in bytes,
-        ('st_atime', float),  # time of most recent access,
-        ('st_mtime', float),  # time of most recent content modification,
-        ('st_ctime', float)])):  # platform dependent (time of most recent metadata change on Unix, or the time of creation on Windows)
+        ('st_mode', int),
+        ('st_ino', int),
+        ('st_dev', int),
+        ('st_nlink', int),
+        ('st_uid', int),
+        ('st_gid', int),
+        ('st_size', int),
+        ('st_atime', float),
+        ('st_mtime', float),
+        ('st_ctime', float)])):
 
     # For backward compatibility, the return value of stat() is also
     # accessible as a tuple of at least 10 integers giving the most important
@@ -115,26 +115,26 @@ class stat_result(NamedTuple('stat_result', [
     # st_ctime. More items may be added at the end by some implementations.
 
     if sys.version_info >= (3, 3):
-        st_atime_ns = 0  # time of most recent access, in nanoseconds
-        st_mtime_ns = 0  # time of most recent content modification in nanoseconds
-        st_ctime_ns = 0  # platform dependent (time of most recent metadata change on Unix, or the time of creation on Windows) in nanoseconds
+        st_atime_ns = ...  # type: int
+        st_mtime_ns = ...  # type: int
+        st_ctime_ns = ...  # type: int
 
     # On some Unix systems (such as Linux), the following attributes may also
     # be available:
-    st_blocks = 0  # number of blocks allocated for file
-    st_blksize = 0  # filesystem blocksize
-    st_rdev = 0  # type of device if an inode device
-    st_flags = 0  # user defined flags for file
+    st_blocks = ...  # type: int
+    st_blksize = ...  # type: int
+    st_rdev = ...  # type: int
+    st_flags = ...  # type: int
 
     # On other Unix systems (such as FreeBSD), the following attributes may be
     # available (but may be only filled out if root tries to use them):
-    st_gen = 0  # file generation number
-    st_birthtime = 0  # time of file creation
+    st_gen = ...  # type: int
+    st_birthtime = ...  # type: int
 
     # On Mac OS systems, the following attributes may also be available:
-    st_rsize = 0
-    st_creator = 0
-    st_type = 0
+    st_rsize = ...  # type: int
+    st_creator = ...  # type: int
+    st_type = ...  # type: int
 
 statvfs_result = NamedTuple('statvfs_result', [
     ('f_bsize', int),
@@ -233,7 +233,7 @@ def rename(src: _PathType, dst: _PathType) -> None: ...
 def renames(old: _PathType, new: _PathType) -> None: ...
 def rmdir(path: _PathType) -> None: ...
 @overload
-def stat_float_times(newvalue: bool = ...) -> None: ...
+def stat_float_times(newvalue: bool) -> None: ...
 @overload
 def stat_float_times() -> bool: ...
 def stat(path: _PathType) -> stat_result: ...

stdlib/3/os/__init__.pyi

@@ -146,16 +146,16 @@ elif sys.version_info >= (3, 5):
         def stat(self) -> stat_result: ...
 
 class stat_result(NamedTuple('stat_result', [
-        ('st_mode', int),  # protection bits,
-        ('st_ino', int),  # inode number,
-        ('st_dev', int),  # device,
-        ('st_nlink', int),  # number of hard links,
-        ('st_uid', int),  # user id of owner,
-        ('st_gid', int),  # group id of owner,
-        ('st_size', int),  # size of file, in bytes,
-        ('st_atime', float),  # time of most recent access,
-        ('st_mtime', float),  # time of most recent content modification,
-        ('st_ctime', float)])):  # platform dependent (time of most recent metadata change on Unix, or the time of creation on Windows)
+        ('st_mode', int),
+        ('st_ino', int),
+        ('st_dev', int),
+        ('st_nlink', int),
+        ('st_uid', int),
+        ('st_gid', int),
+        ('st_size', int),
+        ('st_atime', float),
+        ('st_mtime', float),
+        ('st_ctime', float)])):
 
     # For backward compatibility, the return value of stat() is also
     # accessible as a tuple of at least 10 integers giving the most important
@@ -164,26 +164,26 @@ class stat_result(NamedTuple('stat_result', [
     # st_ctime. More items may be added at the end by some implementations.
 
     if sys.version_info >= (3, 3):
-        st_atime_ns = 0  # time of most recent access, in nanoseconds
-        st_mtime_ns = 0  # time of most recent content modification in nanoseconds
-        st_ctime_ns = 0  # platform dependent (time of most recent metadata change on Unix, or the time of creation on Windows) in nanoseconds
+        st_atime_ns = ...  # type: int
+        st_mtime_ns = ...  # type: int
+        st_ctime_ns = ...  # type: int
 
     # On some Unix systems (such as Linux), the following attributes may also
     # be available:
-    st_blocks = 0  # number of blocks allocated for file
-    st_blksize = 0  # filesystem blocksize
-    st_rdev = 0  # type of device if an inode device
-    st_flags = 0  # user defined flags for file
+    st_blocks = ...  # type: int
+    st_blksize = ...  # type: int
+    st_rdev = ...  # type: int
+    st_flags = ...  # type: int
 
     # On other Unix systems (such as FreeBSD), the following attributes may be
     # available (but may be only filled out if root tries to use them):
-    st_gen = 0  # file generation number
-    st_birthtime = 0  # time of file creation
+    st_gen = ...  # type: int
+    st_birthtime = ...  # type: int
 
     # On Mac OS systems, the following attributes may also be available:
-    st_rsize = 0
-    st_creator = 0
-    st_type = 0
+    st_rsize = ...  # type: int
+    st_creator = ...  # type: int
+    st_type = ...  # type: int
 
 statvfs_result = NamedTuple('statvfs_result', [
     ('f_bsize', int),
@@ -322,7 +322,7 @@ if sys.version_info >= (3, 5):
     @overload
     def scandir(path: bytes) -> Iterator[DirEntry[bytes]]: ...
 @overload
-def stat_float_times(newvalue: bool = ...) -> None: ...
+def stat_float_times(newvalue: bool) -> None: ...
 @overload
 def stat_float_times() -> bool: ...
 def stat(path: _PathType) -> stat_result: ...