Skip to content

Commit b57ac02

Browse files
q10facebook-github-bot
authored andcommitted
Fix setup scripts for OSS ROCm (pytorch#1000)
Summary: Pull Request resolved: facebookresearch/FBGEMM#1000 - Sometimes we would like to test FBGEMM OSS inside FB devservers. However, the scripts currently assume an OSS CI environment with Ubuntu, and so the setup scripts fail with error, which this diff fixes. X-link: pytorch#3909 Reviewed By: sryap Differential Revision: D72255342 Pulled By: q10 fbshipit-source-id: c6361e8439269b553fdc55ebf01a04d283fea873
1 parent ef16f46 commit b57ac02

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.github/scripts/fbgemm_gpu_test.bash

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ test_setup_conda_environment () {
363363
install_cuda "${env_name}" "${pytorch_variant_version}" || return 1
364364
install_cudnn "${env_name}" "${HOME}/cudnn-${pytorch_variant_version}" "${pytorch_variant_version}" || return 1
365365
# Install ROCm tools and runtime
366-
elif [ "$pytorch_variant_type" == "rocm" ]; then
366+
elif [[ "$pytorch_variant_type" == "rocm" ]] && ! [[ "$(hostname)" =~ ^.*facebook.com$ ]]; then
367367
install_rocm_ubuntu "${env_name}" "${pytorch_variant_version}" || return 1
368368
fi
369369

.github/scripts/utils_system.bash

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,8 @@ print_gpu_info () {
133133
if [[ "${BUILD_FROM_NOVA}" != '1' ]]; then
134134
echo "################################################################################"
135135
echo "[INFO] Printing general display info ..."
136-
install_system_packages lshw
136+
install_system_packages hostname lshw
137+
print_exec hostname
137138
print_exec sudo lshw -C display
138139
fi
139140

0 commit comments

Comments
 (0)