-
Notifications
You must be signed in to change notification settings - Fork 174
Support ES2025 JSON modules #780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I started working on import attributes, which IIRC is a pre-requisite for this, before the Xmas break. I hope to get back to it soon! |
I wrote a custom patch for this a while ago, hopefully I can find it in my backups, I probably didn't implement it really well as it used a it still may be worth it to look at(?) |
Sure thing, send it over if you can find it! |
Couldn't find it unfortunately, I could only find a bit of chat with my friend and bit of scraps of the patch, but not much I'm afraid could in theory quickly write it again if I can remember how I did it |
I have managed to write the patch again, not really an equivalent to the previous one as I have decided to not introduce many/any breaking changes, couldn't upload the patch in the issue as GitHub has issues with it on Linux, so I have made GitHub gist instead: Haven't tested it for leaks yet, if there are any possible improvements, I'll be glad to implement them. I have gotten an idea to implement support for JSON modules in |
Very useful, I'll take a look! Or would you rather send it as a PR, enable 262 tests and handle feedback like so? |
That would work, should I also implement JSON modules while at it? Reaction is enough |
See https://github.com/tc39/proposal-json-modules
The text was updated successfully, but these errors were encountered: