Skip to content

Commit 5cb9657

Browse files
authored
chore: deprecate python 3.8 (#391)
1 parent fe13559 commit 5cb9657

File tree

5 files changed

+13
-14
lines changed

5 files changed

+13
-14
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ jobs:
4242
run: cargo fmt --check
4343

4444
Test:
45-
continue-on-error: ${{ matrix.python-version == '3.13' }}
4645
env:
4746
UNSAFE_PYO3_SKIP_VERSION_CHECK: ${{ matrix.unsafe-pyo3-skip-version-check }}
4847
strategy:
@@ -54,8 +53,11 @@ jobs:
5453
include:
5554
- os: ubuntu-latest
5655
python-version: "3.13"
57-
allow-prereleases: true
56+
allow-prereleases: false
5857
unsafe-pyo3-skip-version-check: 1
58+
- os: ubuntu-latest
59+
python-version: "3.12"
60+
allow-prereleases: false
5961
- os: ubuntu-latest
6062
python-version: "3.11"
6163
allow-prereleases: false
@@ -65,9 +67,6 @@ jobs:
6567
- os: ubuntu-latest
6668
python-version: 3.9
6769
allow-prereleases: false
68-
- os: ubuntu-latest
69-
python-version: 3.8
70-
allow-prereleases: false
7170
runs-on: "${{ matrix.os }}"
7271
steps:
7372
- name: Harden Runner

.github/workflows/publish.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,15 +49,15 @@ jobs:
4949
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
5050
- uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b
5151
with:
52-
python-version: 3.8
52+
python-version: 3.9
5353
architecture: x64
5454

5555
- uses: PyO3/maturin-action@ea5bac0f1ccd0ab11c805e2b804bfcb65dac2eab
5656
with:
5757
manylinux: auto
5858
target: ${{ matrix.platform }}
5959
command: build
60-
args: --release --sdist -o dist -i 3.8 3.9 3.10 3.11 3.12 3.13
60+
args: --release --sdist -o dist -i 3.9 3.10 3.11 3.12 3.13
6161

6262
- name: Upload wheels
6363
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # 4.4.3
@@ -74,7 +74,7 @@ jobs:
7474
strategy:
7575
matrix:
7676
target: [x64]
77-
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
77+
python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
7878
steps:
7979
- name: Harden Runner
8080
uses: step-security/harden-runner@0080882f6c36860b6ba35c610c98ce87d4e2f26f
@@ -107,7 +107,7 @@ jobs:
107107
attestations: write # persist the attestation
108108
strategy:
109109
matrix:
110-
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
110+
python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
111111
target: ['universal2', 'x86_64-apple-darwin']
112112
steps:
113113
- name: Harden Runner
@@ -162,10 +162,10 @@ jobs:
162162
with:
163163
toolchain: "stable"
164164

165-
- name: Set up Python 3.8
165+
- name: Set up Python 3.9
166166
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
167167
with:
168-
python-version: 3.8
168+
python-version: 3.9
169169

170170
- uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
171171
with:

ci/deploy_mac.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#!/usr/bin/env bash
22

33
maturin publish \
4-
--interpreter python3.8 \
4+
--interpreter python3.9 \
55
--username __token__ \
66
--password "$MATURIN_PASSWORD" \
77
--no-sdist

noxfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import nox
22

33

4-
@nox.session(python=["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"])
4+
@nox.session(python=["3.9", "3.10", "3.11", "3.12", "3.13"])
55
def test(session):
66
session.install("-rrequirements-dev.txt")
77
session.install("-e", ".", "--no-build-isolation")

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ build-backend = "maturin"
44

55
[project]
66
name = "tantivy"
7-
requires-python = ">=3.8"
7+
requires-python = ">=3.9"
88

99
[project.optional-dependencies]
1010
dev = [

0 commit comments

Comments
 (0)