Skip to content

Commit d5715a8

Browse files
committed
Build: Add Node 18 to matrix, update default to Node 16
* Some non-CI jobs were still using a default of Node 10 or 14. * Fix warning "Node.js 12 actions are deprecated. … Please update actions/checkout, actions/setup-node, actions/cache"
1 parent 49b20d3 commit d5715a8

File tree

8 files changed

+34
-29
lines changed

8 files changed

+34
-29
lines changed

.github/workflows/CI.yaml

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,11 @@ jobs:
1111
fail-fast: false
1212
matrix:
1313
include:
14+
- name: "Linux: Node 18"
15+
os: ubuntu-20.04
16+
node: 18.x
17+
script: npm run test-nolint
18+
1419
- name: "Linux: Node 16"
1520
# Includes 'firefox', 'chromium', and more.
1621
# https://github.com/actions/virtual-environments/blob/ubuntu20/20220410.2/images/linux/Ubuntu2004-Readme.md
@@ -38,7 +43,7 @@ jobs:
3843

3944
- name: "Integration"
4045
os: ubuntu-20.04
41-
node: 14.x
46+
node: 16.x
4247
script: npm run test-integration
4348

4449
- name: "Windows: Node 16"
@@ -57,9 +62,9 @@ jobs:
5762
PUPPETEER_DOWNLOAD_PATH: "${{ github.workspace }}/.puppeteer_download"
5863
FORCE_COLOR: "1"
5964
steps:
60-
- uses: actions/checkout@v2
65+
- uses: actions/checkout@v3
6166

62-
- uses: actions/cache@v2
67+
- uses: actions/cache@v3
6368
if: ${{ runner.os != 'Windows' }}
6469
with:
6570
path: |
@@ -68,7 +73,7 @@ jobs:
6873
key: ${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
6974

7075
- name: Use Node.js ${{ matrix.node }}
71-
uses: actions/setup-node@v2
76+
uses: actions/setup-node@v3.5.0
7277
with:
7378
node-version: ${{ matrix.node }}
7479

@@ -100,17 +105,17 @@ jobs:
100105
env:
101106
PUPPETEER_DOWNLOAD_PATH: "${{ github.workspace }}/.puppeteer_download"
102107
steps:
103-
- uses: actions/checkout@v2
104-
- uses: actions/cache@v2
108+
- uses: actions/checkout@v3
109+
- uses: actions/cache@v3
105110
with:
106111
path: |
107112
~/.npm
108113
${{ github.workspace }}/.puppeteer_download
109114
key: ${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
110-
- name: Use Node.js 10
111-
uses: actions/setup-node@v2
115+
- name: Use Node.js 16
116+
uses: actions/setup-node@v3.5.0
112117
with:
113-
node-version: 10.x
118+
node-version: 16.x
114119
- name: Install mozjs
115120
run: |
116121
sudo apt-fast install -y libmozjs-68-dev

.github/workflows/browsers-full.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,19 +18,19 @@ jobs:
1818
env:
1919
PUPPETEER_DOWNLOAD_PATH: "${{ github.workspace }}/.puppeteer_download"
2020
steps:
21-
- uses: actions/checkout@v2
21+
- uses: actions/checkout@v3
2222

23-
- uses: actions/cache@v2
23+
- uses: actions/cache@v3
2424
with:
2525
path: |
2626
~/.npm
2727
${{ github.workspace }}/.puppeteer_download
2828
key: ${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
2929

30-
- name: Use Node.js 10
31-
uses: actions/setup-node@v2
30+
- name: Use Node.js 16
31+
uses: actions/setup-node@v3.5.0
3232
with:
33-
node-version: 10.x
33+
node-version: 16.x
3434

3535
- name: Prepare
3636
run: |

.github/workflows/browsers-quick.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,19 @@ jobs:
1010
env:
1111
PUPPETEER_DOWNLOAD_PATH: "${{ github.workspace }}/.puppeteer_download"
1212
steps:
13-
- uses: actions/checkout@v2
13+
- uses: actions/checkout@v3
1414

15-
- uses: actions/cache@v2
15+
- uses: actions/cache@v3
1616
with:
1717
path: |
1818
~/.npm
1919
${{ github.workspace }}/.puppeteer_download
2020
key: ${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
2121

22-
- name: Use Node.js 14
23-
uses: actions/setup-node@v2
22+
- name: Use Node.js 16
23+
uses: actions/setup-node@v3.5.0
2424
with:
25-
node-version: 14.x
25+
node-version: 16.x
2626

2727
- name: Prepare
2828
run: |

.github/workflows/coverage.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,19 @@ jobs:
1010
env:
1111
PUPPETEER_DOWNLOAD_PATH: "${{ github.workspace }}/.puppeteer_download"
1212
steps:
13-
- uses: actions/checkout@v2
13+
- uses: actions/checkout@v3
1414

15-
- uses: actions/cache@v2
15+
- uses: actions/cache@v3
1616
with:
1717
path: |
1818
~/.npm
1919
${{ github.workspace }}/.puppeteer_download
2020
key: ${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
2121

22-
- name: Use Node.js 14
23-
uses: actions/setup-node@v2
22+
- name: Use Node.js 16
23+
uses: actions/setup-node@v3.5.0
2424
with:
25-
node-version: 14.x
25+
node-version: 16.x
2626

2727
- run: npm ci
2828

.github/workflows/doc-search.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
if: ${{ github.repository == 'qunitjs/qunit' }} # skip on forks, needs secret
1111
runs-on: ubuntu-18.04
1212
steps:
13-
- uses: actions/checkout@v2
13+
- uses: actions/checkout@v3
1414

1515
# https://github.com/ruby/setup-ruby
1616
- uses: ruby/setup-ruby@v1

.github/workflows/github-pages.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
DEPLOY_DIR: docs/_site/
1313
DEPLOY_BRANCH: gh-pages
1414
steps:
15-
- uses: actions/checkout@v2
15+
- uses: actions/checkout@v3
1616

1717
- name: Prepare branch
1818
run: |

.github/workflows/reproducible.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ jobs:
1616
if: ${{ github.repository == 'qunitjs/qunit' }} # skip on forks, noisy cron
1717
runs-on: ubuntu-20.04
1818
steps:
19-
- uses: actions/checkout@v2
19+
- uses: actions/checkout@v3
2020

2121
- name: Use Node.js 16
22-
uses: actions/setup-node@v2
22+
uses: actions/setup-node@v3.5.0
2323
with:
2424
node-version: 16.x
2525

.github/workflows/spider-check.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
runs-on: ubuntu-latest
2121
if: ${{ github.repository == 'qunitjs/qunit' }} # skip on forks, noisy cron and likely stale main branch
2222
steps:
23-
- uses: actions/checkout@v2
23+
- uses: actions/checkout@v3
2424
with:
2525
repository: qunitjs/hydra-link-checker
2626
ref: v1.0.2

0 commit comments

Comments
 (0)