Skip to content

Commit b54f469

Browse files
committed
fix: remove toArray()
1 parent 0824ab6 commit b54f469

File tree

3 files changed

+6
-21
lines changed

3 files changed

+6
-21
lines changed

dataset.d.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -161,14 +161,6 @@ export interface Dataset<OutQuad extends BaseQuad = StarQuad, InQuad extends Bas
161161
*/
162162
some(iteratee: (quad: OutQuad, dataset: this) => boolean): boolean;
163163

164-
/**
165-
* Returns the set of quads within the dataset as a host language native sequence, for example an `Array` in
166-
* ECMAScript-262.
167-
*
168-
* Since a `Dataset` is an unordered set, the order of the quads within the returned sequence is arbitrary.
169-
*/
170-
toArray(): OutQuad[];
171-
172164
/**
173165
* Returns an N-Quads string representation of the dataset, preprocessed with
174166
* {@link https://json-ld.github.io/normalization/spec/|RDF Dataset Normalization} algorithm.

rdfjs-tests.ts

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@ function test_dataset() {
349349
const dataset2Reduce2: boolean[] = dataset2.reduce((acc: boolean[], quad: BaseQuad, dataset: Dataset<BaseQuad>) => acc, []);
350350
const dataset2Reduce3: string = dataset2.reduce((acc: string, quad: BaseQuad, dataset: Dataset<BaseQuad>) => acc, '');
351351
const dataset2Some: boolean = dataset2.some((quad: BaseQuad, dataset: Dataset<BaseQuad>) => true);
352-
const dataset2ToArray: BaseQuad[] = dataset2.toArray();
352+
const dataset2ToArray: BaseQuad[] = [...dataset2];
353353
const dataset2ToCanonical: string = dataset2.toCanonical();
354354
const dataset2ToStream: Stream<BaseQuad> = dataset2.toStream();
355355
const dataset2ToString: string = dataset2.toString();
@@ -389,7 +389,7 @@ function test_dataset() {
389389
const dataset4Reduce2: boolean[] = dataset4.reduce((acc: boolean[], quad: QuadBnode, dataset: Dataset<QuadBnode>) => acc, []);
390390
const dataset4Reduce3: string = dataset4.reduce((acc: string, quad: QuadBnode, dataset: Dataset<QuadBnode>) => acc, '');
391391
const dataset4Some: boolean = dataset4.some((quad: QuadBnode, dataset: Dataset<QuadBnode>) => true);
392-
const dataset4ToArray: QuadBnode[] = dataset4.toArray();
392+
const dataset4ToArray: QuadBnode[] = [...dataset4];
393393
const dataset4ToCanonical: string = dataset4.toCanonical();
394394
const dataset4ToStream: Stream<QuadBnode> = dataset4.toStream();
395395
const dataset4ToString: string = dataset4.toString();
@@ -428,7 +428,7 @@ function test_dataset() {
428428
const dataset6Reduce2: boolean[] = dataset6.reduce((acc: boolean[], quad: StarQuad, dataset: Dataset) => acc, []);
429429
const dataset6Reduce3: string = dataset6.reduce((acc: string, quad: StarQuad, dataset: Dataset) => acc, '');
430430
const dataset6Some: boolean = dataset6.some((quad: StarQuad, dataset: Dataset) => true);
431-
const dataset6ToArray: StarQuad[] = dataset6.toArray();
431+
const dataset6ToArray: StarQuad[] = [...dataset6];
432432
const dataset6ToCanonical: string = dataset6.toCanonical();
433433
const dataset6ToStream: Stream = dataset6.toStream();
434434
const dataset6ToString: string = dataset6.toString();
@@ -468,7 +468,7 @@ function test_dataset() {
468468
const dataset8Reduce2: boolean[] = dataset8.reduce((acc: boolean[], quad: QuadBnodeStar, dataset: Dataset<QuadBnodeStar>) => acc, []);
469469
const dataset8Reduce3: string = dataset8.reduce((acc: string, quad: QuadBnodeStar, dataset: Dataset<QuadBnodeStar>) => acc, '');
470470
const dataset8Some: boolean = dataset8.some((quad: QuadBnodeStar, dataset: Dataset<QuadBnodeStar>) => true);
471-
const dataset8ToArray: QuadBnodeStar[] = dataset8.toArray();
471+
const dataset8ToArray: QuadBnodeStar[] = [...dataset8];
472472
const dataset8ToCanonical: string = dataset8.toCanonical();
473473
const dataset8ToStream: Stream<QuadBnodeStar> = dataset8.toStream();
474474
const dataset8ToString: string = dataset8.toString();
@@ -606,10 +606,6 @@ class DatasetExt extends DatasetCoreExt implements Dataset {
606606
throw new Error("Method not implemented.");
607607
}
608608

609-
toArray(): StarQuad[] {
610-
throw new Error("Method not implemented.");
611-
}
612-
613609
toCanonical(): string {
614610
throw new Error("Method not implemented.");
615611
}
@@ -682,10 +678,6 @@ class DatasetExtPlain extends DatasetExt implements Dataset {
682678
return newInstance;
683679
}
684680

685-
toArray(): PlainQuad[] {
686-
throw new Error("Method not implemented.");
687-
}
688-
689681
union(): Dataset {
690682
const newInstance: DatasetExtPlain = <any> {};
691683
return newInstance;

tsconfig.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@
22
"compilerOptions": {
33
"module": "commonjs",
44
"lib": [
5-
"es6"
5+
"ES6"
66
],
7+
"target": "ES2015",
78
"strict": true,
89
"noImplicitReturns": true,
910
"noImplicitAny": true,

0 commit comments

Comments
 (0)