Update: make snippet file also non suffix

Author: relastle

Makefile

@@ -23,8 +23,8 @@ test: lint
 	go test -v ./src
 
 .PHONY: integration_test
-integration_test: test
-	(cd ./integration_test && go test -run .)
+integration_test: main
+	(cd ./integration_test && go test -v -run .)
 
 .PHONY: lint
 lint:

src/snippets.go

@@ -11,7 +11,8 @@ import (
 	"github.com/mattn/go-zglob"
 )
 
-const pmySnippetSuffix = "pmy_snippet.txt"
+const pmySnippetSuffix = ".txt"
+const _pmySnippetSuffix = "pmy_snippet.txt"
 
 // SnippetFile represents one Snippet Json file
 // information
@@ -22,11 +23,19 @@ type SnippetFile struct {
 }
 
 func (s SnippetFile) isApplicable(relpath string) bool {
-	return fmt.Sprintf(
-		"%s_%s",
+	if s.Relpath == fmt.Sprintf(
+		"%s%s",
 		relpath,
 		pmySnippetSuffix,
-	) == s.Relpath
+	) {
+		return true
+	}
+
+	return s.Relpath == fmt.Sprintf(
+		"%s_%s",
+		relpath,
+		_pmySnippetSuffix,
+	)
 }
 
 // GetAllSnippetFiles get all pmy snippets txt paths
@@ -45,7 +54,7 @@ func GetAllSnippetFiles() []*SnippetFile {
 		globPattern := fmt.Sprintf(
 			`%v/**/*%v`,
 			snippetRoot,
-			pmySnippetSuffix,
+			_pmySnippetSuffix,
 		)
 		matches, err := zglob.Glob(globPattern)
 		if err != nil {

src/snippets_test.go

@@ -0,0 +1,69 @@
+package pmy
+
+import "testing"
+
+// TestIsApplicable tests if applicability of
+// snippet is correctly works
+func TestIsApplicable(t *testing.T) {
+	testcases := []struct {
+		description  string
+		path         string
+		basename     string
+		relpath      string
+		givenRelpath string
+		expectedRes  bool
+	}{
+		{
+			description:  "valid pattern",
+			path:         "./snippets/curl/test.txt",
+			basename:     "test.txt",
+			relpath:      "curl/test.txt",
+			givenRelpath: "curl/test",
+			expectedRes:  true,
+		},
+		{
+			description:  "invalid pattern",
+			path:         "./snippets/curl/test.txt",
+			basename:     "test.txt",
+			relpath:      "curl/test.txt",
+			givenRelpath: "curl/testhoge",
+			expectedRes:  false,
+		},
+		//////////////////////////////////////////////////
+		// !!!!!!!! TODO: deprecated test !!!!!!!!!!
+		//////////////////////////////////////////////////
+		{
+			description:  "(deprecated) valid pattern",
+			path:         "./snippets/curl/test_pmy_snippet.txt",
+			basename:     "test_pmy_snippet.txt",
+			relpath:      "curl/test_pmy_snippet.txt",
+			givenRelpath: "curl/test",
+			expectedRes:  true,
+		},
+		{
+			description:  "(deprecated) valid pattern",
+			path:         "./snippets/curl/test_pmy_snippet.txt",
+			basename:     "test_pmy_snippet.txt",
+			relpath:      "curl/testhoge_pmy_snippet.txt",
+			givenRelpath: "curl/test",
+			expectedRes:  false,
+		},
+	}
+
+	for _, testcase := range testcases {
+		target := &SnippetFile{
+			Path:     testcase.path,
+			Basename: testcase.basename,
+			Relpath:  testcase.relpath,
+		}
+		res := target.isApplicable(testcase.givenRelpath)
+		if !(res == testcase.expectedRes) {
+			t.Errorf(
+				"test failed (%v): resulting res %v is not equal to %v",
+				testcase.description,
+				res,
+				testcase.expectedRes,
+			)
+		}
+	}
+}