Skip to content

Commit 3e76068

Browse files
Fix non linux builds and add --version to icloud (#1231)
1 parent 3bc89ab commit 3e76068

File tree

4 files changed

+15
-12
lines changed

4 files changed

+15
-12
lines changed

.github/workflows/build-package.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -575,7 +575,7 @@ jobs:
575575
576576
- name: Build Release Executables
577577
run: |
578-
scripts/build_bin2 icloudpd icloud && \
578+
scripts/build_bin1 icloudpd && \
579579
scripts/build_bin1 icloud && \
580580
mv dist/icloud dist/icloud-${{inputs.icloudpd_version}}-macos-amd64 && \
581581
mv dist/icloudpd dist/icloudpd-${{inputs.icloudpd_version}}-macos-amd64
@@ -621,7 +621,7 @@ jobs:
621621
622622
- name: Build Release Executables
623623
run: |
624-
scripts/build_bin2 icloudpd icloud && \
624+
scripts/build_bin1 icloudpd && \
625625
scripts/build_bin1 icloud && \
626626
mv dist/icloud dist/icloud-${{inputs.icloudpd_version}}-windows-amd64 && \
627627
mv dist/icloudpd dist/icloudpd-${{inputs.icloudpd_version}}-windows-amd64

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ scripts/build
121121
Building platform executables:
122122

123123
``` sh
124-
scripts/build_bin2 icloudpd icloud
124+
scripts/build_bin1 icloudpd
125125
scripts/build_bin1 icloud
126126
```
127127
Note: that command is for Linux, including devcontainers. Windows & macOS scripts must be executed on respective platforms.

scripts/build_bin2

Lines changed: 0 additions & 9 deletions
This file was deleted.

src/pyicloud_ipd/cmdline.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
from typing import NoReturn, Sequence
1212

1313
from foundation.core import identity
14+
from foundation import version_info_formatted
1415
from pyicloud_ipd.base import PyiCloudService
1516
from pyicloud_ipd.exceptions import PyiCloudFailedLoginException
1617
from pyicloud_ipd.file_match import FileMatchPolicy
@@ -178,8 +179,19 @@ def main(args: Sequence[str] | None = None) -> NoReturn:
178179
help="Root domain for requests to iCloud. com or cn",
179180
)
180181

182+
parser.add_argument(
183+
"--version",
184+
action="store_true",
185+
dest="version",
186+
help="Show the version, commit hash and timestamp",
187+
)
188+
181189
command_line = parser.parse_args(args)
182190

191+
if command_line.version:
192+
print(version_info_formatted())
193+
sys.exit(0)
194+
183195
username: str | None = command_line.username.strip() or None
184196
password: str | None = command_line.password.strip() or None
185197
domain = command_line.domain

0 commit comments

Comments
 (0)