You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I managed to fix it. Putting it here as it may help others.
The problem was due to a dependency (tonic-build) having rustfmt in its features section in cargo.toml:
@pietroalbini if rustfmt isn't available on the latest nightly, should we refuse to update the toolchain or instead remove the rustfmt component? I lean towards not updating but I could be convinced otherwise.
Activity
jyn514 commentedon Dec 7, 2019
@Lokathor It looks like this is fixed in new versions of fermium, probably because of #407. Can you take a look at https://docs.rs/fermium/0.1.4/src/fermium/SDL2-v2.0.8-x86_64-pc-windows-msvc.rs.html#4692-4695 and make sure it looks about right?
Lokathor commentedon Dec 7, 2019
Well, that's correct, but probably because I have since stopped using bindgen on
docs.rs
. The file you linked is just permanently in the repo: https://github.com/Lokathor/fermium/blob/master/src/SDL2-v2.0.8-x86_64-pc-windows-msvc.rsbut i guess we can close this and someone else will report if it's still a problem later.
jyn514 commentedon Dec 7, 2019
I'd actually rather keep it open until I know it's fixed, sorry we took so long you found a workaround instead.
jyn514 commentedon Mar 23, 2020
Mentoring instructions:
update_toolchain
, calltoolchain.add_component("rustfmt")
.If you have any questions, feel free to reach out here or on Discord.
elmurci commentedon Mar 23, 2020
add_component
requires two parameters:self.toolchain.add_component(&self.workspace, "rustfmt")?;
elmurci commentedon Mar 24, 2020
@jyn514 the solution above didn't work...
jyn514 commentedon Mar 24, 2020
What do you mean by didn't work? Can you put up a draft branch?
elmurci commentedon Mar 24, 2020
adding the command:
self.toolchain.add_component(&self.workspace, "rustfmt")?;
to
update_toolchain
jyn514 commentedon Mar 24, 2020
@elmurci can you join the discord so I can help you debug without spamming notifications for people watching the issue? https://discord.gg/f7mTXPW
elmurci commentedon Mar 24, 2020
I managed to fix it. Putting it here as it may help others.
The problem was due to a dependency (tonic-build) having
rustfmt
in its features section incargo.toml
:I solved it by disabling
tonic-build
'srustfmt
dependency in my project'scargo.toml
:After doing this it built correctly.
jyn514 commentedon Mar 30, 2020
@pietroalbini if
rustfmt
isn't available on the latest nightly, should we refuse to update the toolchain or instead remove the rustfmt component? I lean towards not updating but I could be convinced otherwise.pietroalbini commentedon Mar 31, 2020
I'd prefer not updating as well.